Andy Seaborne wrote: > On 23/11/11 10:50, Paolo Castagna wrote: >> [email protected] wrote: >>> Modified: incubator/jena/Jena2/jena/trunk/NOTICE >>> URL: >>> http://svn.apache.org/viewvc/incubator/jena/Jena2/jena/trunk/NOTICE?rev=1205358&r1=1205357&r2=1205358&view=diff >>> >>> ============================================================================== >>> >>> --- incubator/jena/Jena2/jena/trunk/NOTICE (original) >>> +++ incubator/jena/Jena2/jena/trunk/NOTICE Wed Nov 23 10:42:02 2011 >>> @@ -3,3 +3,6 @@ Copyright 2011 The Apache Software Found >>> >>> This product includes software developed at >>> The Apache Software Foundation (http://www.apache.org/). >>> + >>> +This product includes software developed by >>> +Plugged In Software and under a BSD license. >> >> Thanks Andy. >> >> Precisely the "software developed by Plugged In Software" is >> contributions to: >> >> - ExtendedHandler.java >> - XMLHandler.java >> - ARP.java > > As mentioned in LICENSE.
Ok. > Or are you telling me that has to go in NOTICE as well? No, I was just surfacing here the fact that it's only a small interface. Changing/rewriting should be possible (and it should be trivial). I'll give it a try and post a patch. > (No other project I looked at did anything other that to say they > contained other stuff.) > >> >> I don't think there are other files involved in relation to Plugged In >> Software. >> >> ExtendedHandler is an interface with just four methods. >> I doubt anyone else other than us is using it. > > Mulgara? Well, if we change interface and method names, users will need to adapt to changes or stick with an older version. In this particular (and not usual/common) case, I think this would be the right approach. If I have time, I'll look at Mulgara to check if/how they use the interface. Paolo > >> Probably renaming the interface and method names (which are not great) >> would be good anyway. >> XMLHandler uses a nullScopeHandler (i.e. empty) implementation of >> ExtendedHandler. Ditto. >> ARP has setter/getter for ARPHandlers and indirectly for >> ExtendedHandler. Trivial. >> >> Paolo > >
