[
https://issues.apache.org/jira/browse/JENA-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187005#comment-13187005
]
Andy Seaborne commented on JENA-195:
------------------------------------
As it stands, I think it will be tricky for users to know what this feature is
and how it works without having to delve into the implementation code.
1/ This needs a bit more in the javadoc to expose it to users. I don't think
javadoc should point to JIRA which points to an email thread, rather the
javadoc should contain the documentation for the implemented design without
reference elsewhere. e.g. what is the key in the Map? what's the value?
encoding policy? Reserved words?
2/ In addition to javadoc and other documentation, how about an example in
src-examples? c.f. ExampleDBpedia
3/ Shouldn't this also work with QueryEngineHTTP? If it's in QueryEngineHTTP
then it works for SERVICE and QueryExecutionFactory.sparqlService.
4/ Might this need some Explain.explain? I'm not sure what the best level is
here, whether the post param-building string needs logging (cryptic but
complete) or the query (readable but incomplete).
Maybe it's time to have a page on the website for all-things-remote, including
this feature.
> Allow users to specify query parameters when they use SERVICE
> <...?name=value> in their SPARQL queries
> ------------------------------------------------------------------------------------------------------
>
> Key: JENA-195
> URL: https://issues.apache.org/jira/browse/JENA-195
> Project: Jena
> Issue Type: Improvement
> Components: ARQ
> Reporter: Paolo Castagna
> Assignee: Paolo Castagna
> Priority: Minor
> Attachments: JENA-195.patch
>
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> SPARQL endpoints might require or allow additional query parameters, if we
> want to use those endpoints with SERVICE <...> in SPARQL queries we must
> support query parameters and allow users to use SERVICE <...?name=value> in
> their SPARQL queries.
> Service.java can look in the Context for additional parameters.
> Parameters need to be kept separate and grouped on a per SERVICE endpoint
> basis (in order to avoid exposing parameter values to wrong places).
> A Map<String, Map<String,List<String>>> can be uses to map SERVICE endpoint
> URLs to parameter-->values.
> OpService.java probably needs to change (to keep the parameters separate from
> the SERVICE endpoint URL).
> See also this thread on jena-users:
> http://markmail.org/thread/wc5hvr3b3uzy2mrk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
