[
https://issues.apache.org/jira/browse/JENA-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Seaborne updated JENA-185:
-------------------------------
Attachment: SDB-Sybase-v1.patch
Thanks for all the work for this. I've looked at the files submitted and there
a couple of things I'd like to check with you.
I've turned your contribution into a patch (attached to JIRA) which is created
relative to the current SVN state.
1/ The files you uploaded were produced against an old copy of SDB - I've fixed
up the differences (e.g. Apache copyright headers) and produced a patch.
Patches are easier to deal with than a collection of files for different
packages because a patch can be applied in singel operation. Patches are also
reversible.
If possible we can both work from from current Apache SVN state? It makes it a
lot easier for me to see what is in the contribution.
https://svn.apache.org/repos/asf/incubator/jena/Jena2/SDB/trunk/
We do need to check that the differences between the versions don't materially
affect the Sybase addition.
2/ There are no changes to the tests area - have you run the test on Sybase?
I was expecting new files for testing/StoreDesc/ and testing/StoreDescSimple/
then commented out sections of testing/store-list.ttl and
testing/store-list-simple.ttl.
The latter two files control which stores are configured in for running the
tests.
Comments from a code review: this things didn't look right to me (obviously
this is from looking at the code, not running it):
A/ SDBCompile
There is no
if ( StoreUtils.isSyBase(store) )
Is Sybase fine with the default settings for SDBRequest:
LeftJoinTranslation = true ; // Does the DB support general join
expressions?
LimitOffsetTranslation = false ; // Does the DB grok the Limit/Offset SQL?
DistinctTranslation = true ; // Some DBs can't do DISTINCt on CLOBS.
B/ StoreSimpleSyBase
It says:
new FormatterSimpleHSQL
shouldn't that be:
new FormatterSimpleSyBase ??
It says:
new GenerateSQL
shouldn't that be:
new GenerateSQLSyBase
C/ StoreTriplesNodesHashSyBase
again, it says:
new GenerateSQL
shouldn't that be:
new GenerateSQLSyBase
> Connect SDB to SyBase
> ---------------------
>
> Key: JENA-185
> URL: https://issues.apache.org/jira/browse/JENA-185
> Project: Jena
> Issue Type: Improvement
> Components: SDB
> Affects Versions: SDB 1.3.4
> Reporter: AIME
> Labels: patch
> Fix For: SDB 1.3.4
>
> Attachments: DatabaseType.java, FmtLayout2HashSyBase.java,
> FmtLayout2IndexSyBase.java, FormatterSimpleSyBase.java,
> GenerateSQLSyBase.java, JDBC.java, SDB-Sybase-v1.patch, SDBCompile.java,
> StoreFactory.java, StoreSimpleSyBase.java, StoreTriplesNodesHashSyBase.java,
> StoreTriplesNodesIndexSyBase.java, StoreUtils.java,
> TupleLoaderHashSyBase.java, TupleLoaderIndexSyBase.java
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Modify files :
> - com.hp.hpl.jena.sdb.sql.JDBC
> - com.hp.hpl.jena.sdb.store.DatabaseType
> - com.hp.hpl.jena.sdb.store.StoreFactory
> - com.hp.hpl.jena.sdb.util.StoreUtils
> - com.hp.hpl.jena.sdb.compiler.SDBCompile
> Add files :
> - com.hp.hpl.jena.sdb.layout1.FormatterSimpleSyBase.java
> - com.hp.hpl.jena.sdb.layout1.StoreSimpleSybase.java
> - com.hp.hpl.jena.sdb.layout2.index.FmtLayout2IndexSyBase.java
> - com.hp.hpl.jena.sdb.layout2.index.StoreTriplesNodesIndexSyBase.java
> - com.hp.hpl.jena.sdb.layout2.index.TupleLoaderIndexSyBase.java
> - com.hp.hpl.jena.sdb.layout2.hash.FmtLayout2HashSyBase.java
> - com.hp.hpl.jena.sdb.layout2.hash.StoreTriplesNodesHashSyBase.java
> - com.hp.hpl.jena.sdb.layout2.hash.TupleLoaderHashSyBase.java
> - com.hp.hpl.jena.sdb.core.sqlnode.GenerateSQLSyBase
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
