Re: svn commit: r1238939 - /incubator/jena/Jena2/LARQ/trunk/src/test/java/org/apache/jena/larq/TestAssemblerLARQ.java

[Andy Seaborne]

On 01/02/12 05:12, casta...@apache.org wrote:
Author: castagna
Date: Wed Feb  1 05:12:46 2012
New Revision: 1238939
URL: http://svn.apache.org/viewvc?rev=1238939&view=rev
Log:
This should fix the 4 failures in TestAssemblerLARQ.

Modified:
     
incubator/jena/Jena2/LARQ/trunk/src/test/java/org/apache/jena/larq/TestAssemblerLARQ.java

Modified: 
incubator/jena/Jena2/LARQ/trunk/src/test/java/org/apache/jena/larq/TestAssemblerLARQ.java
URL: 
http://svn.apache.org/viewvc/incubator/jena/Jena2/LARQ/trunk/src/test/java/org/apache/jena/larq/TestAssemblerLARQ.java?rev=1238939&r1=1238938&r2=1238939&view=diff
==============================================================================
--- 
incubator/jena/Jena2/LARQ/trunk/src/test/java/org/apache/jena/larq/TestAssemblerLARQ.java
 (original)
+++ 
incubator/jena/Jena2/LARQ/trunk/src/test/java/org/apache/jena/larq/TestAssemblerLARQ.java
 Wed Feb  1 05:12:46 2012
@@ -44,7 +44,7 @@ import com.hp.hpl.jena.rdf.model.Resourc
  import com.hp.hpl.jena.sparql.core.assembler.AssemblerUtils;
  import com.hp.hpl.jena.tdb.TDBFactory;
  import com.hp.hpl.jena.tdb.assembler.VocabTDB;
-import com.hp.hpl.jena.tdb.store.DatasetGraphTDB;
+import com.hp.hpl.jena.tdb.transaction.DatasetGraphTransaction;

  public class TestAssemblerLARQ {

@@ -80,7 +80,7 @@ public class TestAssemblerLARQ {
          assertTrue(thing instanceof Dataset) ;
          Dataset ds = (Dataset)thing ;
          ds.asDatasetGraph() ;
-        assertTrue(((Dataset)thing).asDatasetGraph() instanceof 
DatasetGraphTDB) ;
+        assertTrue(((Dataset)thing).asDatasetGraph() instanceof 
DatasetGraphTransaction) ;

          assertNotNull(LARQ.getDefaultIndex()) ;

It would be safer to test for either case (if you must test the internal 
implementation of another system :-)

A one-time transaction dataset is a subclass of DatasetGraphTDB.
DatasetGraphTDB may arise if working on the direct base storage.

DatasetGraphTransaction is the equivalent of a JDBC connection.

        Andy