[ 
https://issues.apache.org/jira/browse/JENA-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206284#comment-13206284
 ] 

Andy Seaborne commented on JENA-210:
------------------------------------

I tried to apply this patch and then tested it using arq.rsparql = Fuseki with 
JENA-209 (gzip)

problems:
1/ HttpQuery.execCommon asks for "Transfer-Encoding", that should be 
"Content-Encoding"
   HttpURLConnection.getContentEncoding() is better still.

In what environment has this been tested?

2/ QueryEngineHTTP.execSelect sets the "Accept" header to content
   Nothing looks in the response for the Content-type.

3/ gzip/inflate is on by default.
   I think for now off is a better default.

Other:
StringUtils.join : see StrUtils.strjoin (the reasons for having two so similar 
is historical).

Is text/boolean a registered MIME type?
  I can't find it and have instead put in application/sparql-results+json 
support

QueryEngineHTTP.convertStreamToString depended on the platform default charset. 

Outstanding questions:
A/ What's been tested?
B/ What is text/boolean?
C/ default client-size setting of compression - on or off?
                
> Make QueryEngineHttp more configurable
> --------------------------------------
>
>                 Key: JENA-210
>                 URL: https://issues.apache.org/jira/browse/JENA-210
>             Project: Jena
>          Issue Type: Improvement
>          Components: ARQ
>    Affects Versions: ARQ 2.9.0
>            Reporter: Rob Vesse
>              Labels: http, query, results, sparql
>             Fix For: ARQ 2.9.1
>
>         Attachments: HttpQueryEnhancements.patch
>
>
> The current QueryEngineHttp is somewhat limited in that the Accept header is 
> hardcoded to SPARQL Results XML or RDF/XML depending on the usage of the 
> engine and there are a number of other features lacking including timeouts 
> and support for requesting and reading compressed content.
> The submitted patch here adds the following features:
> 1 - Configurable Content Type support
> A QueryEngineHttp instance can be configured to request different content 
> types as required by the users.  For CONSTRUCT/DESCRIBE whether the requested 
> content type is valid is verified using RIOT and the parser for reading 
> responses into models automatically selected.  For ASK/SELECT the supported 
> content types are defined in hard-coded lists and the parser selected via if 
> statements.
> In the future it is envisaged that ASK/SELECT supported format detection 
> could be improved by wiring into whatever new machinery around handling 
> result formats that ARQ/RIOT eventually supplies
> 2 - Configuration Timeouts
> Support for configuring Connection and Read Timeouts for queries
> 3 - GZip and Deflate Compression Support
> Support for specifying that the client will allow GZip/Deflate encoded 
> content to be sent to it and for ensuring that the returned InputStream gets 
> appropriately wrapped so the content is decompressed as read

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to