Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/jenkins
  Commit: 1472ce133bccd3c441b6726b4090ea6aae8b848b
      
https://github.com/jenkinsci/jenkins/commit/1472ce133bccd3c441b6726b4090ea6aae8b848b
  Author: Kohsuke Kawaguchi <[email protected]>
  Date:   2012-02-09 (Thu, 09 Feb 2012)

  Changed paths:
    M core/src/main/java/hudson/util/PersistedList.java

  Log Message:
  -----------
  added a convenience method that replaces just one item in the list


  Commit: a71d037b8450c2dc690f51e2e082dc58375b9aa3
      
https://github.com/jenkinsci/jenkins/commit/a71d037b8450c2dc690f51e2e082dc58375b9aa3
  Author: Kohsuke Kawaguchi <[email protected]>
  Date:   2012-02-09 (Thu, 09 Feb 2012)

  Changed paths:
    M core/src/main/java/hudson/ExtensionFinder.java
  M test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
  M test/src/main/java/org/jvnet/hudson/test/TestExtensionLoader.java

  Log Message:
  -----------
  Revisited the way Guice creates an injector during unit test

The motivation of this is to enable test code to inject components from 
Jenkins, which means we need a single Injector that can see all of those, 
including @TestExtension and regular @Extension. Then I realized that the 
current implementation is broken, as it creates two independent Injectors. This 
has other undesirable side effects like @TestExtension components not being 
able to inject @Extensions, etc.

I briefly experimented with hierarchical Injectors (where we first create 
Injector that loads @Extension then create another that loads @TestExtension as 
a child), but this was hard to get right as we have no control over which 
ExtensionFinder gets instantiated first --- we'd be at the mercy of SezPoz.

So the eventual approach is to allow a single GuiceFinder to recognize multiple 
annotations. This also works well with our using child injector for installing 
plugins without restart


  Commit: 61ec0fc64a34b8ce809939cc50e4d94a78f97a58
      
https://github.com/jenkinsci/jenkins/commit/61ec0fc64a34b8ce809939cc50e4d94a78f97a58
  Author: Kohsuke Kawaguchi <[email protected]>
  Date:   2012-02-09 (Thu, 09 Feb 2012)

  Changed paths:
    M maven-plugin/src/main/java/hudson/maven/MavenComputerListener.java

  Log Message:
  -----------
  added doc


  Commit: 83ad02d9ecdaf188f14d3377e65847cd9904d662
      
https://github.com/jenkinsci/jenkins/commit/83ad02d9ecdaf188f14d3377e65847cd9904d662
  Author: Kohsuke Kawaguchi <[email protected]>
  Date:   2012-02-09 (Thu, 09 Feb 2012)

  Changed paths:
    M test/src/test/java/hudson/slaves/JNLPLauncherTest.java

  Log Message:
  -----------
  Using injection for assertions, which is better


Compare: https://github.com/jenkinsci/jenkins/compare/4378e87...83ad02d

Reply via email to