Branch: refs/heads/master
Home: https://github.com/jenkinsci/gerrit-trigger-plugin
Commit: ef82c75b5ce7433936a57108e1a3f6638093768a
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/ef82c75b5ce7433936a57108e1a3f6638093768a
Author: Brad Larson <[email protected]>
Date: 2012-05-21 (Mon, 21 May 2012)
Changed paths:
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Fix behavior of canceling old patch sets
There were several problems with canceling jobs created by old patch sets
when new patch sets are uploaded.
We were removing old jobs when scheduled() was called, but then removed()
was also called, which would cancel the newly-added build we care about.
Instead, we now store the PatchsetCreated event to track the jobs, and
cancel all jobs for a particular Change # when a new patch set is uploaded
but only remove the exact job when remove() is called.
There was also a problem in calling Future.cancel(), as documented in
https://issues.jenkins-ci.org/browse/JENKINS-13829. This was worked around
by storing the parameters used to create each build and canceling jobs with
the same parameters. This is more in-line with how jobs are canceled from
the Web UI.
Commit: f75572cbcb30c4ef875c1996a88795463d8d2419
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/f75572cbcb30c4ef875c1996a88795463d8d2419
Author: Tomas Westling <[email protected]>
Date: 2012-05-29 (Tue, 29 May 2012)
Changed paths:
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Merge pull request #23 from bklarson/master
Fix behavior of canceling old patch sets
Compare:
https://github.com/jenkinsci/gerrit-trigger-plugin/compare/3452290...f75572c
