Branch: refs/heads/master
Home: https://github.com/jenkinsci/android-emulator-plugin
Commit: 17edc6550f1a7f49f0af1ed15eb97d71aac7723e
https://github.com/jenkinsci/android-emulator-plugin/commit/17edc6550f1a7f49f0af1ed15eb97d71aac7723e
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2012-09-17 (Mon, 17 Sep 2012)
Changed paths:
M src/main/java/hudson/plugins/android_emulator/AndroidEmulator.java
M src/main/java/hudson/plugins/android_emulator/EmulatorConfig.java
M src/main/java/hudson/plugins/android_emulator/SdkInstaller.java
M src/main/java/hudson/plugins/android_emulator/util/Utils.java
Log Message:
-----------
'isUnix' flag mostly unneeded.
In relation to a531f90453e25378efc5a1b1e15b55a99c25f709, I noticed that
the way the 'isUnix' flag is used is mostly redundant. It's computed by
the master and then passed with a closure to be exected on the slave.
But once your code starts to execute on the slave, its JVM already knows
what platform it is running on. So it's more concise and faster not to
pass around this flag from the master.
Similarly, when a method signature returns a File, like
Utils.getHomeDirectory(), then you are by definition already executing
on the target JVM, so these functions shouldn't take the 'isUnix'
parameter. It's concise, faster, and less error prone to just let this
function computes whether it's running on an Unix or not.
This commit eliminates those redundant uses of the 'isUnix' flag from
the signature.
I don't know if other plugins started depending on these signatures,
and/or if you'd like to maintain API compatibility, so I'm sending this
in as a pull request. Please feel free to disregard if that is the case.
Commit: dcd9999ab39050584352692e2d74ba51a1a85af1
https://github.com/jenkinsci/android-emulator-plugin/commit/dcd9999ab39050584352692e2d74ba51a1a85af1
Author: Christopher Orr <[email protected]>
Date: 2012-09-23 (Sun, 23 Sep 2012)
Changed paths:
M src/main/java/hudson/plugins/android_emulator/AndroidEmulator.java
M src/main/java/hudson/plugins/android_emulator/EmulatorConfig.java
M src/main/java/hudson/plugins/android_emulator/SdkInstaller.java
M src/main/java/hudson/plugins/android_emulator/util/Utils.java
Log Message:
-----------
Merge pull request #16 from kohsuke/master
Get rid of the redundant 'isUnix' flag.
Compare:
https://github.com/jenkinsci/android-emulator-plugin/compare/a531f90453e2...dcd9999ab390
