Branch: refs/heads/master
Home: https://github.com/jenkinsci/jenkins
Commit: 17b94a044a03e49ca7f4a87af69a993354ec0df1
https://github.com/jenkinsci/jenkins/commit/17b94a044a03e49ca7f4a87af69a993354ec0df1
Author: Wadeck Follonier <[email protected]>
Date: 2018-04-26 (Thu, 26 Apr 2018)
Changed paths:
M core/src/main/java/hudson/util/HttpResponses.java
A core/src/main/java/jenkins/diagnostics/RootUrlNotSetMonitor.java
M core/src/main/java/jenkins/install/InstallState.java
M core/src/main/java/jenkins/install/InstallUtil.java
M core/src/main/java/jenkins/install/SetupWizard.java
M core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java
A
core/src/main/java/jenkins/org/apache/commons/validator/routines/DomainValidator.java
A
core/src/main/java/jenkins/org/apache/commons/validator/routines/InetAddressValidator.java
A
core/src/main/java/jenkins/org/apache/commons/validator/routines/RegexValidator.java
A
core/src/main/java/jenkins/org/apache/commons/validator/routines/UrlValidator.java
A core/src/main/java/jenkins/util/UrlHelper.java
M core/src/main/resources/jenkins/diagnostics/Messages.properties
A
core/src/main/resources/jenkins/diagnostics/RootUrlNotSetMonitor/message.jelly
A
core/src/main/resources/jenkins/diagnostics/RootUrlNotSetMonitor/message.properties
A core/src/main/resources/jenkins/install/Messages.properties
A
core/src/main/resources/jenkins/install/SetupWizard/setupWizardConfigureInstance.jelly
A
core/src/main/resources/jenkins/install/SetupWizard/setupWizardConfigureInstance.properties
A
core/src/main/resources/jenkins/install/SetupWizard/setupWizardConfigureInstance_fr.properties
M
core/src/main/resources/jenkins/install/SetupWizard/setupWizardFirstUser.jelly
M
core/src/main/resources/jenkins/install/SetupWizard/setupWizardFirstUser.properties
M
core/src/main/resources/jenkins/install/SetupWizard/setupWizardFirstUser_fr.properties
M core/src/main/resources/jenkins/install/pluginSetupWizard.properties
M core/src/main/resources/jenkins/install/pluginSetupWizard_fr.properties
A core/src/test/java/jenkins/util/UrlHelperTest.java
A test/src/test/java/jenkins/diagnostics/RootUrlNotSetMonitorTest.java
M war/src/main/js/api/securityConfig.js
M war/src/main/js/pluginSetupWizardGui.js
A war/src/main/js/templates/configureInstance.hbs
Log Message:
-----------
[JENKINS-31661] Check the root url (Admin monitor + Wizard) (#3082)
* [JENKINS-31661] Add an administrative monitor to check the root url
configuration
- add the monitor + test
* - corrections requested by Oleg in code review
* - add a field to fill during SetupWizard for the rootUrl (default value using
javascript but editable)
- WIP : missing the translation
* - revert whitespace change
* - little refactoring of js methods
* - translation added
* - modification requested during PR by Jesse
* - renaming proposed by Keith
* - rework to have a new page in the SetupWizard for the root URL
* Correct relevant non-conflicting merge changes
* - in case of skip => also skip the instance configuration
- terminate => finish (+ uppercase)
- replace double single quotes
- add help message in the wizard to inform admins
- correct the installState serialization problem
- update working (admin monitor + wizard)
* address Daniel's comment
- skip all steps will show two messages instead of one (like before when
clicking on skip twice)
- skip => not now
- remove margin and adjust padding for the wizard forms
- add the "if possible"
* address Arnaud's comment on the sauter vs passer
* address Liam's comment
* correct previous commit typo
* correct previous commit typo (2)
* add blank end line
* address James' comment
* address Daniel's comment
* address Devin's comment
- implement error management in the wizard
- provide different message in the monitor in case of null / invalid url
- add an helper to validate URL (even with _ in domain)
- add @Restricted
* - also update the monitor test to be consistent with its new behavior
* address Devin's comments
* correct header files
* include relevant classes for the url validation from commons-validator:1.6
* Move Apache classes in a more standard package
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
