Branch: refs/heads/master
Home: https://github.com/jenkinsci/gerrit-trigger-plugin
Commit: 63209f292a78e718d62e6c78860795d9934b42f2
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/63209f292a78e718d62e6c78860795d9934b42f2
Author: Mark Butcher <[email protected]>
Date: 2013-02-18 (Mon, 18 Feb 2013)
Changed paths:
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerParameters.java
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/manual/ManualTriggerAction.java
M
gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger/config.jelly
A
gerrithudsontrigger/src/main/webapp/trigger/help-NoNameAndEmailParameters.html
Log Message:
-----------
Workaround for parameter issues on Windows
I've found that in some configurations (particularly with Gradle and on
Windows) that there are problems with the way some parameters are passed
on the commandline (to Gradle). I've not been able to sort out the exact
cause of the problem (I originally attempted to fix by changing the way
things were escaped but was unsuccessful). Essentially the problem I've
seen is that gradle can't process the commandline arguements correctly
when triggered by this plugin (but not otherwise and I don't see the
same problems with, say, the Maven plugin).
To work around the problem I've added another checkbox under the
advanced options which stops this plugin from setting the 'name and
email' parameters for a build. Without those parameters things work
nicely for me. I'd rather not maintain a fork just for my company so I'd
like to get this workaround (or something like it) merged if possible
(let me know if there is anything I can do help out with that).
I think this also fixes an issue where it appeared that manually triggered
changes were not respecting the escape quotes setting (it seemed to be
forced to false but it's also entirely possible that I was missing
another source the setting).
Commit: f2ef88e7fd4f0e0ceb9faa8329db39a0dc45ddfd
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/f2ef88e7fd4f0e0ceb9faa8329db39a0dc45ddfd
Author: Mark Butcher <[email protected]>
Date: 2013-02-19 (Tue, 19 Feb 2013)
Changed paths:
M
gerrithudsontrigger/src/main/webapp/trigger/help-NoNameAndEmailParameters.html
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/DuplicatesUtil.java
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/Setup.java
Log Message:
-----------
Fixing unit test issues
Commit: 062f73f25573d076ae5cfb9d2810ad77eeccb5b5
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/062f73f25573d076ae5cfb9d2810ad77eeccb5b5
Author: Robert Sandell <[email protected]>
Date: 2013-02-21 (Thu, 21 Feb 2013)
Changed paths:
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerParameters.java
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/manual/ManualTriggerAction.java
M
gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger/config.jelly
A
gerrithudsontrigger/src/main/webapp/trigger/help-NoNameAndEmailParameters.html
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/DuplicatesUtil.java
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/Setup.java
Log Message:
-----------
Merge pull request #41 from macbutch/escaping-on-windows
Workaround for parameter issues on Windows
Compare:
https://github.com/jenkinsci/gerrit-trigger-plugin/compare/eb3e54107495...062f73f25573
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
