Branch: refs/heads/juraj-728-null-commit-issue
Home: https://github.com/jenkinsci/codescene-plugin
Commit: a6c2780c61e5b1a4dcf6775da0bcbb299ac86290
https://github.com/jenkinsci/codescene-plugin/commit/a6c2780c61e5b1a4dcf6775da0bcbb299ac86290
Author: Juraj Martinka <juma...@gmail.com>
Date: 2018-12-04 (Tue, 04 Dec 2018)
Changed paths:
M src/main/java/org/jenkinsci/plugins/codescene/CodeSceneBuilder.java
M src/main/java/org/jenkinsci/plugins/codescene/Domain/Commit.java
Log Message:
-----------
ENTERPRISE-728: WIP fix "null commit" issue.
Commit: a8d51fc3cc247e2b84fb40c2dee061a716f4c00d
https://github.com/jenkinsci/codescene-plugin/commit/a8d51fc3cc247e2b84fb40c2dee061a716f4c00d
Author: Juraj Martinka <juma...@gmail.com>
Date: 2018-12-04 (Tue, 04 Dec 2018)
Changed paths:
M src/main/java/org/jenkinsci/plugins/codescene/CodeSceneBuilder.java
Log Message:
-----------
ENTERPRISE-728: Use base revision if no previous successful commit is
available.
This was a problem when the build was first run for a new branch without any
previous OK build.
In that case, the "GIT_PREVIOUS_SUCCESSFUL_COMMIT" env variable was set to null,
which lead to an exception in the Commit class constructor and early job
termination.
The issue was introduced by recent refactoring (using Commit domain class
instead of pure Strings).
However, even the former solution (with Strings) seems to be suboptimal,
because in that case following git command was used to get commit range:
```
git log --pretty='%%H' ..<current_commit_sha>"
```
, which lead to an empty commit range.
Compare:
https://github.com/jenkinsci/codescene-plugin/compare/a6c2780c61e5^...a8d51fc3cc24
**NOTE:** This service has been marked for deprecation:
https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
