Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/stash-pullrequest-builder-plugin
  Commit: e42b06bfcbbcb5f059d8a0fcf968d4f5baf8d4ca
      
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/e42b06bfcbbcb5f059d8a0fcf968d4f5baf8d4ca
  Author: Robert Hencke <robert.hen...@gmail.com>
  Date:   2019-04-24 (Wed, 24 Apr 2019)

  Changed paths:
    M 
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java

  Log Message:
  -----------
  StashBuildTrigger: Use isBuildable() instead of isDisabled()

There are reasons for a job to be non-buildable other than the project
being disabled. The Jenkins core uses isBuildable(), not isDisabled()
when deciding whether to run a job.

Instead of checking that stashPullRequestsBuilder is not null, check that
this.job is not null. Both are set in start(). Both would be null before
start() and non-null objects afterwards.

Use this.job instead of stashPullRequestsBuilder.getProject(). Both
values should be the same, as stashPullRequestsBuilder.getProject()
returns the value passed to the StashPullRequestsBuilder constructor.
That is the job argument to start(), which also becomes the value of
this.job.


-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to