Branch: refs/heads/master
Home: https://github.com/jenkinsci/ssh-credentials-plugin
Commit: c6521dad8841fef117ece93f93478b69eb3882fe
https://github.com/jenkinsci/ssh-credentials-plugin/commit/c6521dad8841fef117ece93f93478b69eb3882fe
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-04-15 (Mon, 15 Apr 2013)
Changed paths:
M
src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/SSHAuthenticator.java
M src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/SSHUser.java
M
src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/impl/JSchSSHPublicKeyAuthenticator.java
M
src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/impl/TrileadSSHPasswordAuthenticator.java
M
src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/impl/TrileadSSHPublicKeyAuthenticator.java
Log Message:
-----------
Improving the error diagnostics.
The overall motivations are:
- reporting the error to logging is less useful since it's less contextual.
The log message doesn't indicate where/why the authentication is attempted.
- for a person looking at a failure that the authentication is failing, it's
not obvious that the server log contains more details.
(and this plugin allows scoped credentials that doesn't necessarily belong
to someone who has access to the server output.)
For this, pass in TaskListener and have implementations report errors to them.
A provision is made for the case the caller wants to suppress the error message.
The authenticate() is deprecated to make it very obvious that the caller should
supply a valid one.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
