Branch: refs/heads/master
Home: https://github.com/jenkinsci/external-resource-dispatcher-plugin
Commit: d2e20769100136e726a38a26c777ed3787fe6ffb
https://github.com/jenkinsci/external-resource-dispatcher-plugin/commit/d2e20769100136e726a38a26c777ed3787fe6ffb
Author: Patrik Johansson <[email protected]>
Date: 2013-04-10 (Wed, 10 Apr 2013)
Changed paths:
M .gitignore
Log Message:
-----------
Added Eclipse project files to .gitignore
Commit: b87513b074b74d2cec18945ebe76fb9106faf314
https://github.com/jenkinsci/external-resource-dispatcher-plugin/commit/b87513b074b74d2cec18945ebe76fb9106faf314
Author: Patrik Johansson <[email protected]>
Date: 2013-04-10 (Wed, 10 Apr 2013)
Changed paths:
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/ExternalResourceQueueTaskDispatcher.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/ReleaseRunListener.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/SelectionCriteria.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/data/ExternalResource.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/utils/resourcemanagers/DefaultExternalResourceManager.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/utils/resourcemanagers/ExternalResourceManager.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/utils/resourcemanagers/NoopExternalResourceManager.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/utils/resourcemanagers/ResourceMonitorExternalResourceManager.java
M
src/test/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/utils/NoopExternalResourceManagerHudsonTest.java
M
src/test/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/utils/resourcemanagers/ExternalResourceManagerTest.java
Log Message:
-----------
[FIXED JENKINS-17469] Clearer separation of concerns
Refactoring classses to make the concerns of each class clearer.
All state changes of an ExternalResource are now made by the
ExternalResourceManager instead of whatever object is requesting the
resource.
To make this happen, the reserve/lock/release methods have been re-written
using the
Template Method Pattern, implementing the state change flow in the abstract
base class
and letting sub-classes continue to implement the inner locking mechanism by
calling the
abstract method reservation/locking/releasingMechanism().
A sequence diagram of the new plugin flow can be seen here:
http://www.websequencediagrams.com/cgi-bin/cdraw?lz=cGFydGljaXBhbnQgRXh0ZXJuYWxSZXNRdWV1ZVRhc2tEaXNwYXRjaGVyCgAfDFNlbGVjdGlvbkNyaXRlcmlhABENUmVsZWFzZVJ1bkxpc3RlbgAuDwBdC291cmNlTWFuYWcAUg9BdmFpbGFiaWxpdHlGaWx0ACQfCgpvcHQgV2hlbiBsb29raW5nIGZvciBleGVjdXRvcgoAgT0eLT4AXRM6IGdldACBGxBzTGlzdChub2RlKQAeNmYAgUcFRW5hYmxlZGFuZACBYQdsZSgAGjdnZXRNYXRjaGluZwCBHAkAKCQAgm4XOiByZXNlcnZlKHIAgxcHAIFcDQCDJAwAMhM6IHNldFIAOwZkKCkKZW5kAIMPC2pvYiBzdGFydHMKAIQvESAtLT4AexgAgQoIKSAgW2lmIG5vdACBHQhkXSAAgQYYIACBURMgOgCBEQ4AcxMAgX4bbG9jawCBXDpMb2NrAIF9F2ZpbmlzaGVzCgCGJhIAgXsaIHIAhl8GKCkAgWoZAIJAEgB-DG51bGwAgxwG&s=default
Commit: 60dbb37dad4deff885e04b0f01d37180744ceea4
https://github.com/jenkinsci/external-resource-dispatcher-plugin/commit/60dbb37dad4deff885e04b0f01d37180744ceea4
Author: Patrik Johansson <[email protected]>
Date: 2013-05-03 (Fri, 03 May 2013)
Changed paths:
M .gitignore
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/ExternalResourceQueueTaskDispatcher.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/ReleaseRunListener.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/SelectionCriteria.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/data/ExternalResource.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/utils/resourcemanagers/DefaultExternalResourceManager.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/utils/resourcemanagers/ExternalResourceManager.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/utils/resourcemanagers/NoopExternalResourceManager.java
M
src/main/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/utils/resourcemanagers/ResourceMonitorExternalResourceManager.java
M
src/test/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/utils/NoopExternalResourceManagerHudsonTest.java
M
src/test/java/com/sonyericsson/jenkins/plugins/externalresource/dispatcher/utils/resourcemanagers/ExternalResourceManagerTest.java
Log Message:
-----------
Merge pull request #1 from patrik-johansson/refactoring
Refactoring classses to make the concerns of each class clearer.
All state changes of an ExternalResource are now made by the
ExternalResourceManager instead of whatever object is requesting the
resource.
Compare:
https://github.com/jenkinsci/external-resource-dispatcher-plugin/compare/7f1ad98200d7...60dbb37dad4d
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
