Branch: refs/heads/master
Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin
Commit: 4ba7f645bbdc373ecd4cb1affffb786a0f2588f6
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/4ba7f645bbdc373ecd4cb1affffb786a0f2588f6
Author: Pavel Roskin <plros...@gmail.com>
Date: 2019-08-20 (Tue, 20 Aug 2019)
Changed paths:
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java
M
src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java
Log Message:
-----------
Construct StashApiClient in StashBuildTrigger
Use a single StashRepository constructor. Don't test StashApiClient in
StashRepositoryTest. Remove WireMock from StashRepositoryTest.
Commit: 45da95f53725fdda09048d48c8383e77a1a0d7f1
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/45da95f53725fdda09048d48c8383e77a1a0d7f1
Author: Pavel Roskin <plros...@gmail.com>
Date: 2019-08-20 (Tue, 20 Aug 2019)
Changed paths:
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java
Log Message:
-----------
StashBuildTrigger: Don't throw NullPointerException unnecessarily
If job is null, report it and return. Looking at the Jenkins code, it
should not happen, but Javadoc makes no explicit promises, and the job
argument is not annotated with @Nonnull.
Report all possible exceptions in start(), not just NullPointerException.
The calling code may not be well prepared to deal with exceptions.
Compare:
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/4cedf70ffacf...45da95f53725
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/4cedf7-45da95%40github.com.
