Branch: refs/heads/refactoring
Home: https://github.com/jenkinsci/git-plugin
Commit: 1a65736ab45c2f6e574f892d19056e6c5a5f15f5
https://github.com/jenkinsci/git-plugin/commit/1a65736ab45c2f6e574f892d19056e6c5a5f15f5
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-20 (Thu, 20 Jun 2013)
Changed paths:
M src/test/java/hudson/plugins/git/GitSCMTest.java
Log Message:
-----------
Potentially backward compatibility breaking change
In the original version of GitSCM.buildEnvVar, the code reads as follows:
-------
Revision rev = fixNull(getBuildData(build, false)).getLastBuiltRevision();
String singleBranch = getSingleBranch(build);
if (singleBranch != null){
env.put(GIT_BRANCH, singleBranch);
} else if (rev != null) {
Branch branch = rev.getBranches().iterator().next();
env.put(GIT_BRANCH, branch.getName());
}
-------
As you can see, the code takes a different path if getSingleBranch(build)
returns non-null, and when it does, the branch name does not contain the
repository name, such as just "master". OTOH, Branch.getName() always returns a
branch name prefixed by the repository name, such as "origin/master".
I noticed this behaviour difference when I was working on a test regression in
this, and upon understanding what's going on, I think the original code creates
a behaviour inconsistency --- either we should always return "origin/master" or
"master", regardless of whether the kind of checkout happens to be a single
branch build. In this change, I'm opting with "origin/master", given that when
multiple repositories are involved, "master" alone won't be unique.
Commit: 06147009f4ae1b86087194fb4c84a1b3db4f19bb
https://github.com/jenkinsci/git-plugin/commit/06147009f4ae1b86087194fb4c84a1b3db4f19bb
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-20 (Thu, 20 Jun 2013)
Changed paths:
M src/main/java/hudson/plugins/git/GitSCM.java
M src/main/java/hudson/plugins/git/GitSCMBackwardCompatibility.java
M src/main/java/hudson/plugins/git/GitStatus.java
A src/main/java/hudson/plugins/git/extensions/impl/IgnoreNotifyCommit.java
M src/main/resources/hudson/plugins/git/GitSCM/config.jelly
R src/main/resources/hudson/plugins/git/GitSCM/help-ignoreNotifyCommit.html
A
src/main/resources/hudson/plugins/git/extensions/impl/IgnoreNotifyCommit/help.html
M src/test/java/hudson/plugins/git/AbstractGitTestCase.java
M src/test/java/hudson/plugins/git/GitPublisherTest.java
M src/test/java/hudson/plugins/git/GitSCMTest.java
M src/test/java/hudson/plugins/git/GitStatusTest.java
M src/test/java/hudson/plugins/git/MultipleSCMTest.java
Log Message:
-----------
Extracted ignoreNotifyCommit to a fake extension point
Commit: 7ca97066c8348bd3311c29fa6f5432421f44c5a4
https://github.com/jenkinsci/git-plugin/commit/7ca97066c8348bd3311c29fa6f5432421f44c5a4
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-20 (Thu, 20 Jun 2013)
Changed paths:
M
src/main/resources/hudson/plugins/git/extensions/impl/RelativeTargetDirectory/config.groovy
Log Message:
-----------
wrong UI control
Commit: 686d9da6dac811c16ce55bc7445693a9e45f7ee9
https://github.com/jenkinsci/git-plugin/commit/686d9da6dac811c16ce55bc7445693a9e45f7ee9
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-20 (Thu, 20 Jun 2013)
Changed paths:
M src/main/java/hudson/plugins/git/GitSCM.java
M src/main/java/hudson/plugins/git/GitSCMBackwardCompatibility.java
A src/main/java/hudson/plugins/git/extensions/impl/ScmName.java
M src/main/resources/hudson/plugins/git/GitSCM/config.jelly
R src/main/resources/hudson/plugins/git/GitSCM/help-scmName.html
A
src/main/resources/hudson/plugins/git/extensions/impl/ScmName/config.groovy
A src/main/resources/hudson/plugins/git/extensions/impl/ScmName/help.html
M src/test/java/hudson/plugins/git/AbstractGitTestCase.java
M src/test/java/hudson/plugins/git/GitPublisherTest.java
M src/test/java/hudson/plugins/git/GitSCMTest.java
M src/test/java/hudson/plugins/git/GitStatusTest.java
M src/test/java/hudson/plugins/git/MultipleSCMTest.java
Log Message:
-----------
Split off ScmName as a fake extension
Commit: 58d72f702ea44a25bd9df2d24ac20901ad9f1d7b
https://github.com/jenkinsci/git-plugin/commit/58d72f702ea44a25bd9df2d24ac20901ad9f1d7b
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-21 (Fri, 21 Jun 2013)
Changed paths:
M src/main/java/hudson/plugins/git/GitSCM.java
M src/main/java/hudson/plugins/git/GitSCMBackwardCompatibility.java
A src/main/java/hudson/plugins/git/extensions/impl/LocalBranch.java
M src/main/resources/hudson/plugins/git/GitSCM/config.jelly
R src/main/resources/hudson/plugins/git/GitSCM/help-localBranch.html
A
src/main/resources/hudson/plugins/git/extensions/impl/LocalBranch/config.groovy
A
src/main/resources/hudson/plugins/git/extensions/impl/LocalBranch/help.html
Log Message:
-----------
split off LocalBranch into its own extension point
Commit: 6c632238eebf55495d53f2b9126dc49a25d545a0
https://github.com/jenkinsci/git-plugin/commit/6c632238eebf55495d53f2b9126dc49a25d545a0
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-21 (Fri, 21 Jun 2013)
Changed paths:
M src/test/java/hudson/plugins/git/GitSCMTest.java
Log Message:
-----------
test case for basic configuration roundtrip
Commit: c474147081b185662df7948b36a4f5461bf935c2
https://github.com/jenkinsci/git-plugin/commit/c474147081b185662df7948b36a4f5461bf935c2
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-21 (Fri, 21 Jun 2013)
Changed paths:
M src/main/java/hudson/plugins/git/UserRemoteConfig.java
Log Message:
-----------
for config roundtrip consistency, fix up empty strings
Commit: 19431d8a2565110e61b88dcf3a9637758d10d950
https://github.com/jenkinsci/git-plugin/commit/19431d8a2565110e61b88dcf3a9637758d10d950
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-21 (Fri, 21 Jun 2013)
Changed paths:
M src/main/java/hudson/plugins/git/GitSCM.java
M src/main/java/hudson/plugins/git/extensions/impl/LocalBranch.java
M src/main/java/hudson/plugins/git/extensions/impl/PreBuildMerge.java
M src/test/java/hudson/plugins/git/AbstractGitTestCase.java
M src/test/java/hudson/plugins/git/GitPublisherTest.java
M src/test/java/hudson/plugins/git/GitStatusTest.java
M src/test/java/hudson/plugins/git/MultipleSCMTest.java
Log Message:
-----------
fix up for the local branch split
Commit: 839e342bee14bfeb6436a4091a3d6c2d9b5fb5d3
https://github.com/jenkinsci/git-plugin/commit/839e342bee14bfeb6436a4091a3d6c2d9b5fb5d3
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-21 (Fri, 21 Jun 2013)
Changed paths:
M src/main/java/hudson/plugins/git/GitSCM.java
M src/main/java/hudson/plugins/git/extensions/impl/SubmoduleOption.java
Log Message:
-----------
databinding requires this name to be consistent
Commit: 83e57e6ed4353bc9e86fa6f2cac066f5fb6e1ec1
https://github.com/jenkinsci/git-plugin/commit/83e57e6ed4353bc9e86fa6f2cac066f5fb6e1ec1
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-21 (Fri, 21 Jun 2013)
Changed paths:
M src/main/resources/hudson/plugins/git/GitSCM/config.jelly
M
src/main/resources/hudson/plugins/git/extensions/impl/SubmoduleOption/config.groovy
Log Message:
-----------
Yay! Got rid of the advanced configuration section.
Every fringe use case is now implemented as GitSCMExtension
Commit: b164e75a97b92e23e5dbf48f00e7c3cb0ff52f39
https://github.com/jenkinsci/git-plugin/commit/b164e75a97b92e23e5dbf48f00e7c3cb0ff52f39
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-21 (Fri, 21 Jun 2013)
Changed paths:
M src/main/java/hudson/plugins/git/GitSCM.java
Log Message:
-----------
a bit of simplification
Commit: 9211def3c07eda8bd034b55d324ec0c7ca5d645a
https://github.com/jenkinsci/git-plugin/commit/9211def3c07eda8bd034b55d324ec0c7ca5d645a
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-21 (Fri, 21 Jun 2013)
Changed paths:
M src/main/java/hudson/plugins/git/GitSCM.java
M src/main/resources/hudson/plugins/git/GitSCM/config.jelly
Log Message:
-----------
follow up bug fixes
Compare:
https://github.com/jenkinsci/git-plugin/compare/9f85893a0b49...9211def3c07e
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
