Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/github-branch-source-plugin
  Commit: 183be61344f2ac520a76dc953b6fc3d321e8fd91
      
https://github.com/jenkinsci/github-branch-source-plugin/commit/183be61344f2ac520a76dc953b6fc3d321e8fd91
  Author: Hutson Betts <[email protected]>
  Date:   2020-05-07 (Thu, 07 May 2020)

  Changed paths:
    M docs/github-app.adoc

  Log Message:
  -----------
  docs(github-app): webhook correction

Update GitHub App documentation to reflect that a GitHub App already has a 
built-in webhook that does not require creating a new webhook using the 
_Webhook_ permission. Furthermore, to take advantage of that built-in webhook, 
events must be enabled on the App's _Permissions_ page.

Otherwise, if you wanted to use a separate webhook created by Jenkins using the 
credentials of the GitHub App, you would need to enable the _Admin_ permission, 
or else you would get the following error and no webhook:

```
Failed to add GitHub webhook for 
GitHubRepositoryName[host=github.example.com,username=test,repository=test]
java.lang.NullPointerException: There are no credentials with admin access to 
manage hooks on 
GitHubRepositoryName[host=github.example.com,username=test,repository=test]
        at 
com.google.common.base.Preconditions.checkNotNull(Preconditions.java:231)
        at 
org.jenkinsci.plugins.github.webhook.WebhookManager$2.applyNullSafe(WebhookManager.java:179)
        at 
org.jenkinsci.plugins.github.webhook.WebhookManager$2.applyNullSafe(WebhookManager.java:175)
```


  Commit: dd91d2dbb909b8d24b251ba562aa8e625d6c06d7
      
https://github.com/jenkinsci/github-branch-source-plugin/commit/dd91d2dbb909b8d24b251ba562aa8e625d6c06d7
  Author: Liam Newman <[email protected]>
  Date:   2020-05-29 (Fri, 29 May 2020)

  Changed paths:
    M docs/github-app.adoc

  Log Message:
  -----------
  Merge pull request #301 from hutson/patch-1

docs(github-app): webhook correction


Compare: 
https://github.com/jenkinsci/github-branch-source-plugin/compare/e47f3cc1c144...dd91d2dbb909

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/github-branch-source-plugin/push/refs/heads/master/e47f3c-dd91d2%40github.com.

Reply via email to