Branch: refs/heads/resolve-scanner-warnings
Home: https://github.com/jenkinsci/git-client-plugin
Commit: 87efbefddcd184928335a2e6f46319c2602d2fc1
https://github.com/jenkinsci/git-client-plugin/commit/87efbefddcd184928335a2e6f46319c2602d2fc1
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2020-10-11 (Sun, 11 Oct 2020)
Changed paths:
M src/test/java/org/jenkinsci/plugins/gitclient/CliGitAPIImplTest.java
M src/test/java/org/jenkinsci/plugins/gitclient/GitClientTest.java
Log Message:
-----------
Better name for version test assertion method
Commit: bfd7acb2d54387935a88a375ec5d78b27c092339
https://github.com/jenkinsci/git-client-plugin/commit/bfd7acb2d54387935a88a375ec5d78b27c092339
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2020-10-11 (Sun, 11 Oct 2020)
Changed paths:
M src/main/java/hudson/plugins/git/GitTool.java
Log Message:
-----------
doCheckHome only needed from POST context
Since the method is only needed from a POST context, it should be
annotated with @RequirePOST. The method does not invoke any risky code
that might make it a security risk, but it is not useful as a GET method,
so require that it must be called with POST.
Commit: 520941bac55346af93fed5b3813e19e8d27402b8
https://github.com/jenkinsci/git-client-plugin/commit/520941bac55346af93fed5b3813e19e8d27402b8
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2020-10-11 (Sun, 11 Oct 2020)
Changed paths:
M src/test/java/jmh/benchmark/GitClientFetchBenchmark.java
M src/test/java/jmh/benchmark/GitClientFetchVanillaBenchmark.java
M src/test/java/jmh/benchmark/GitClientInitBenchmark.java
M src/test/java/jmh/benchmark/GitClientLSRemoteBenchmark.java
M src/test/java/jmh/benchmark/GitClientRedundantFetchBenchmark.java
M src/test/java/org/jenkinsci/plugins/gitclient/CredentialsTest.java
Log Message:
-----------
Avoid method names confused with Stapler methods
The doXyz methods may be misinterpreted as Stapler methods. This is
purely test code, but no reason to use poorly named methods in test
code either.
Compare:
https://github.com/jenkinsci/git-client-plugin/compare/87efbefddcd1%5E...520941bac553
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/git-client-plugin/push/refs/heads/resolve-scanner-warnings/000000-520941%40github.com.
