Branch: refs/heads/master
Home: https://github.com/jenkinsci/acceptance-test-harness
Commit: 8abd520162684ed152469c83fcf5baf82383a7d9
https://github.com/jenkinsci/acceptance-test-harness/commit/8abd520162684ed152469c83fcf5baf82383a7d9
Author: James Nord <jtn...@users.noreply.github.com>
Date: 2020-11-06 (Fri, 06 Nov 2020)
Changed paths:
M src/main/java/org/jenkinsci/test/acceptance/po/Control.java
Log Message:
-----------
fix observed flakyness with click when adding publishers to a build
on some systems clicking a button will fail as the button is obscured by
the "Save"/"Apply" buttons in configuration.
whilst Selenium scrolls it appears as though the click is done whilst
the scrolling is still in progress (the diagnostic screenshot shows
everything is ok) but this is taken very shortly after the test failure.
With this just try and click a few times if the button is obscured.
Ideally we would re-write the Jenkins UX so that the Save/Apply buttons
did not float above other parts of the form but rather where at the
bottom and the form contents would stop above the buttons.
but that is not such an easy fix so for now just try a few times,
Commit: 4c207c07047798ba152acb9d658eaae5e8884918
https://github.com/jenkinsci/acceptance-test-harness/commit/4c207c07047798ba152acb9d658eaae5e8884918
Author: James Nord <jtn...@users.noreply.github.com>
Date: 2020-11-06 (Fri, 06 Nov 2020)
Changed paths:
M src/main/java/org/jenkinsci/test/acceptance/po/Control.java
Log Message:
-----------
fix flakyness in obtaining the yui menus for dropdown
on some systems the menu would fail to be displayed when we tried to
click on it as it is shown asynchronously.
with this change we wait for it to be visible, and once clicked we wait
for it to be not visible also so we know the click has done something.
Commit: 3e7cfbe68651394599aed79a9ecbd097fce23ba6
https://github.com/jenkinsci/acceptance-test-harness/commit/3e7cfbe68651394599aed79a9ecbd097fce23ba6
Author: James Nord <jtn...@users.noreply.github.com>
Date: 2020-11-06 (Fri, 06 Nov 2020)
Changed paths:
M src/main/java/org/jenkinsci/test/acceptance/po/Control.java
Log Message:
-----------
change the way we find and wait for menus to be displayed
the previous change (although it worked) probably worked by fluke.
repeatidly getting the element in a waitFor did not change anything
apart from taking a bit longer to do its thing (which solved the case
but for the wrong reasons).
the menu can be found regardless of if it is visible or not. so we just
find it and then wait for it to become visible.
Commit: 13a110fa2d534cfa571191a8be66c3cab3f5da16
https://github.com/jenkinsci/acceptance-test-harness/commit/13a110fa2d534cfa571191a8be66c3cab3f5da16
Author: James Nord <jtn...@users.noreply.github.com>
Date: 2020-11-06 (Fri, 06 Nov 2020)
Changed paths:
M src/main/java/org/jenkinsci/test/acceptance/po/Control.java
Log Message:
-----------
waitFor already uses the elastic clock so no need to use time
Commit: 99602394a6011516d59d235aa447ab886741542d
https://github.com/jenkinsci/acceptance-test-harness/commit/99602394a6011516d59d235aa447ab886741542d
Author: James Nord <jtn...@users.noreply.github.com>
Date: 2020-11-09 (Mon, 09 Nov 2020)
Changed paths:
M src/main/java/org/jenkinsci/test/acceptance/po/Control.java
Log Message:
-----------
Merge pull request #619 from jtnord/click_and_menu_flakes
deflake `Control.click` and `Control.selectDropdownMenu`
Compare:
https://github.com/jenkinsci/acceptance-test-harness/compare/2f748dcb1885...99602394a601
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/acceptance-test-harness/push/refs/heads/master/2f748d-996023%40github.com.
