Branch: refs/heads/master
Home: https://github.com/jenkinsci/build-failure-analyzer-plugin
Commit: 3800f775d4e7b5312522e49e0ffe5d85ca7c03df
https://github.com/jenkinsci/build-failure-analyzer-plugin/commit/3800f775d4e7b5312522e49e0ffe5d85ca7c03df
Author: Gustaf Lundh <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M
src/main/java/com/sonyericsson/jenkins/plugins/bfa/BuildFailureScanner.java
Log Message:
-----------
Analyze all projects in RunListener.onCompleted() scope
In PR #103 the scope was changed for workflow jobs (and others) to
carry out the BFA analysis in RunListener.onFinalized() scope due
to JENKINS-42755.
I argue that this was the wrong way to remedy the mentioned issue
due to following factors:
1. RunListener.fireCompleted() is executed before a build is
released. When we say 'released' we mean that any waiting upstream
builds can continue (or downstream builds can be triggered).
2. RunListener.fireFinalized() is executed after the build has
been released.
The Build Failure Analyzer plugin was originally written to be
executing in RunListener.onCompleted() scope and then wait for the
analysis to be completed. This means that the waiting upstream
build will wait for its downstream builds to complete (and be
analysed) before doing its own aggregation and analysis.
Changing this behaviour is problematic, since the upstream job is
now (since PR #103) already given the OK to continue executing
before the BFA analysis is executed. And we will see a really bad
racing condition where the upstream build could complete its log
analysis before the downsteam build. This is extra problematic,
if you want to emit messages (mq-notifier plugin) with this kind
of data aggregated.
PR #103 is a complete behavioural change, which essentially hinders
aggregation (and acting upon) issues found in downstream jobs.
I argue that the correct fix should have been in the WorkflowRun,
ensuring that any error messages are printed in the log before the
RunListener.fireCompleted() is executed. This is how most (all?)
other job types handle it today.
In https://github.com/jenkinsci/workflow-job-plugin/pull/184
this behaviour was finally changed to print errors before
RunListener.onCompleted() is fired, and BFA will now be able
to pick up all issues produced in the console log from
RunListener.onCompleted().
NOTE: This PR should not be merged until a new release of the
Workflow Job Plugin is released.
More details can be found in
https://github.com/jenkinsci/workflow-job-plugin/pull/184.
Commit: a2d166f6a904304166282433a5abd4a867b2c31c
https://github.com/jenkinsci/build-failure-analyzer-plugin/commit/a2d166f6a904304166282433a5abd4a867b2c31c
Author: Gustaf Lundh <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M
src/main/java/com/sonyericsson/jenkins/plugins/bfa/BuildFailureScanner.java
Log Message:
-----------
Fix unneeded import
Commit: 98023f23dfb51257a86f074d9c74cd3f576c0ad8
https://github.com/jenkinsci/build-failure-analyzer-plugin/commit/98023f23dfb51257a86f074d9c74cd3f576c0ad8
Author: Gustaf Lundh <[email protected]>
Date: 2021-06-18 (Fri, 18 Jun 2021)
Changed paths:
M pom.xml
M
src/main/resources/com/sonyericsson/jenkins/plugins/bfa/CauseManagement/index.groovy
Log Message:
-----------
Fix permissions errors
Commit: cd11b6d7e8ad7465c1a145055c75d6367a0f8a30
https://github.com/jenkinsci/build-failure-analyzer-plugin/commit/cd11b6d7e8ad7465c1a145055c75d6367a0f8a30
Author: Gustaf Lundh <[email protected]>
Date: 2021-06-18 (Fri, 18 Jun 2021)
Changed paths:
M pom.xml
Log Message:
-----------
Compile Java 8 & add test dependency for pipeline build() cmd
Commit: ab2667991f21b3bdbd20f69f16b2111109aa3a5e
https://github.com/jenkinsci/build-failure-analyzer-plugin/commit/ab2667991f21b3bdbd20f69f16b2111109aa3a5e
Author: Gustaf Lundh <[email protected]>
Date: 2021-06-21 (Mon, 21 Jun 2021)
Changed paths:
M pom.xml
M
src/test/java/com/sonyericsson/jenkins/plugins/bfa/FailureCauseWorkFlowTest.java
Log Message:
-----------
More fixes to pom
Commit: 012d3359d4c355fd44ceb2e245cbe8a77c72724d
https://github.com/jenkinsci/build-failure-analyzer-plugin/commit/012d3359d4c355fd44ceb2e245cbe8a77c72724d
Author: Gustaf Lundh <[email protected]>
Date: 2021-06-22 (Tue, 22 Jun 2021)
Changed paths:
M pom.xml
Log Message:
-----------
Renable java8 compiling
Needed for powermock.
Commit: 22e308cdbd2af7a1e4be74d235ac190d7d93a2e6
https://github.com/jenkinsci/build-failure-analyzer-plugin/commit/22e308cdbd2af7a1e4be74d235ac190d7d93a2e6
Author: Tomas Westling <[email protected]>
Date: 2021-08-12 (Thu, 12 Aug 2021)
Changed paths:
M pom.xml
M
src/main/java/com/sonyericsson/jenkins/plugins/bfa/BuildFailureScanner.java
M
src/main/resources/com/sonyericsson/jenkins/plugins/bfa/CauseManagement/index.groovy
M
src/test/java/com/sonyericsson/jenkins/plugins/bfa/FailureCauseWorkFlowTest.java
Log Message:
-----------
Merge pull request #140 from GLundh/fix-racing-condition
Analyze all projects in RunListener.onCompleted() scope (again)
Compare:
https://github.com/jenkinsci/build-failure-analyzer-plugin/compare/c047ef9ba82a...22e308cdbd2a
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/build-failure-analyzer-plugin/push/refs/heads/master/c047ef-22e308%40github.com.
