Branch: refs/heads/master
Home: https://github.com/jenkinsci/google-play-android-publisher-plugin
Commit: eded82102ab4dc38589a19e624d7da6f31cf50a4
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/eded82102ab4dc38589a19e624d7da6f31cf50a4
Author: Christopher Orr <[email protected]>
Date: 2021-08-16 (Mon, 16 Aug 2021)
Changed paths:
M README.md
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/AbstractPublisherTask.java
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkUploadTask.java
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/InternalAppSharingUploadTask.java
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/TrackAssignmentTask.java
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/TrackPublisherTask.java
M
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisherTest.java
M
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/ReleaseTrackAssignmentBuilderTest.java
Log Message:
-----------
[FIXED JENKINS-65815] Set send-for-review flag as appropriate.
When committing changes, the Google Play API may now respond with:
Changes cannot be sent for review automatically. Please set the query
parameter changesNotSentForReview to true. Once committed, the changes
in this edit can be sent for review from the Google Play Console UI.
It seems that this can happen if the app has had an updated rejected in
the past, and so users are required to visit the Google Play Console and
press the "Send for review" button.
See:
https://support.google.com/googleplay/android-developer/answer/9859751?hl=en#zippy=%2Citem-status
The API now notifies us of this scenario via the above error message,
requiring that we re-submit the changes, but with an "acknowledgement"
flag to indicate that we understand the changes won't be sent to review.
Like the "bundle installation warning" flag, this flow is kinda dumb,
but I guess Google really wanted to force people to explicitly handle
this situation, allowing us to inform the user that their changes won't
be automatically sent for review – which is what we now do.
In addition, I refactored the commit behaviour so that it's shared by
both the app file upload and assignment steps. This removes the handling
of timeouts during upload, which simplifies the code slightly, but I
assume that Google might have fixed that class of errors at some point
in the last seven years…
Commit: c5b1fff4305450eadee63b00f97b19f3d15a936e
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/c5b1fff4305450eadee63b00f97b19f3d15a936e
Author: Christopher Orr <[email protected]>
Date: 2021-08-16 (Mon, 16 Aug 2021)
Changed paths:
M
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisherTest.java
M
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/internal/responses/FakeHttpResponse.java
Log Message:
-----------
Add automated test for changesNotSentForReview scenario.
Commit: 62775d4ee7655e72710d621b87d04af711bc700a
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/62775d4ee7655e72710d621b87d04af711bc700a
Author: Christopher Orr <[email protected]>
Date: 2021-08-16 (Mon, 16 Aug 2021)
Changed paths:
M README.md
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/AbstractPublisherTask.java
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkUploadTask.java
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/InternalAppSharingUploadTask.java
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/TrackAssignmentTask.java
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/TrackPublisherTask.java
M
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisherTest.java
M
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/ReleaseTrackAssignmentBuilderTest.java
M
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/internal/responses/FakeHttpResponse.java
Log Message:
-----------
Merge pull request #45 from jenkinsci/feature/JENKINS-65815-simple
Compare:
https://github.com/jenkinsci/google-play-android-publisher-plugin/compare/47d4e082174a...62775d4ee765
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/google-play-android-publisher-plugin/push/refs/heads/master/47d4e0-62775d%40github.com.
