Branch: refs/heads/master
Home: https://github.com/jenkinsci/gerrit-trigger-plugin
Commit: f1eee7c750c379354e399d3208f9825692bfe765
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/f1eee7c750c379354e399d3208f9825692bfe765
Author: Adam Romanek <[email protected]>
Date: 2021-06-03 (Thu, 03 Jun 2021)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/data/GerritProject.java
A
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/data/GerritProjectForbiddenFilesWithMagicalFileNamesTest.java
Log Message:
-----------
Fix excessive triggers for a change with forbidden files only
With strictForbiddenFileVerification enabled, when the list of files in
a change was fully covered by forbidden file paths, the change was still
considered interesting. That's because the list of files always contains
at least one magical file name: "/COMMIT_MSG" [1]. In some cases a change
may also contain some other magical file names: "/MERGE_LIST" and/or
"/PATCHSET_LEVEL" (at least as of Gerrit 3.4). So after all, when the
list of files was checked against forbidden file paths, the resuling
list of files (tmpFiles) was never empty and the associated job was
being triggered, although it shouldn't have been.
[1]
https://gerrit.googlesource.com/gerrit/+/refs/tags/v3.4.0/java/com/google/gerrit/entities/Patch.java#33
Commit: 23df4a54ad7eb85c0055892b2d36db0a2a2d05b3
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/23df4a54ad7eb85c0055892b2d36db0a2a2d05b3
Author: Robert Sandell <[email protected]>
Date: 2021-09-09 (Thu, 09 Sep 2021)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/data/GerritProject.java
A
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/data/GerritProjectForbiddenFilesWithMagicalFileNamesTest.java
Log Message:
-----------
Merge pull request #444 from
romanek-adam/bugfix/forbidden-files-excessive-trigger
Fix excessive triggers for a change with forbidden files only and
strictForbiddenFileVerification enabled
Compare:
https://github.com/jenkinsci/gerrit-trigger-plugin/compare/e07fd5a821b9...23df4a54ad7e
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/gerrit-trigger-plugin/push/refs/heads/master/e07fd5-23df4a%40github.com.
