Branch: refs/heads/master
Home: https://github.com/jenkinsci/gerrit-trigger-plugin
Commit: 5f672f2db13314377c9db239bdb6ae4491136345
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/5f672f2db13314377c9db239bdb6ae4491136345
Author: Yannack <[email protected]>
Date: 2014-01-06 (Mon, 06 Jan 2014)
Changed paths:
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java
A
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritDelayedApprover.java
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
A
gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritDelayedApprover/config.jelly
M
gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger/config.jelly
A gerrithudsontrigger/src/main/webapp/trigger/help-DelayedApproval.html
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/DuplicatesUtil.java
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/Setup.java
Log Message:
-----------
Delayed approval mechanism [FIXED JENKINS-11409]
This patch introduces the possibility for a delayed approval to be sent
back to Gerrit. This is a relatively advanced use case, so the setting
has been placed in the Advanced section for the Trigger settings.
When one selects "delayed approval", the completion of the build will
NOT send an approval back to Gerrit. Instead, the triggering event stays
open, and needs to be closed later on. This can be done by using the new
post-build action "Send a Gerrit delayed approval". At the moment, this
notifier expects to read the name of the job and build number from build
variables. If these point to an existing build which has a Gerrit event
as a trigger, which has not been submitted due to "delayed approval",
then that approval will be sent. In particular, this allows to modify
the status of that build through other job (e.g., using Groovy scripts),
and mark it UNSTABLE (e.g., if a subsequent build were to fail), which
is a way one can change the result of the Approval in Gerrit.
Amends: fixed broken style and broken unit tests
Commit: 349eade44871967f4005323c922d0f86903c035c
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/349eade44871967f4005323c922d0f86903c035c
Author: Yannack <[email protected]>
Date: 2014-01-15 (Wed, 15 Jan 2014)
Changed paths:
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritDelayedApprover.java
Log Message:
-----------
Placed proper copyright
Commit: 3cf05c8a3244d91fa18a2c4225b35ecfeacc7b16
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/3cf05c8a3244d91fa18a2c4225b35ecfeacc7b16
Author: Yannack <[email protected]>
Date: 2014-02-07 (Fri, 07 Feb 2014)
Changed paths:
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritDelayedApprover.java
M
gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/Messages.properties
M
gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritDelayedApprover/config.jelly
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListenerTest.java
Log Message:
-----------
Added unit-test, general cleanup
- Added a unit-test to lock the delayed approval mechanism in the
"normal" scenario
- Added some output in the build console for the delayed approval
- i18n of the user facing delayed approver texts
- Did some minor code refactoring
Commit: c512069db1936d16eb969eab63d85e111188b0e0
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/c512069db1936d16eb969eab63d85e111188b0e0
Author: Robert Sandell <[email protected]>
Date: 2014-02-10 (Mon, 10 Feb 2014)
Changed paths:
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java
A
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritDelayedApprover.java
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
M
gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/Messages.properties
A
gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritDelayedApprover/config.jelly
M
gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger/config.jelly
A gerrithudsontrigger/src/main/webapp/trigger/help-DelayedApproval.html
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListenerTest.java
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/DuplicatesUtil.java
M
gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/Setup.java
Log Message:
-----------
Merge pull request #122 from yannack/delayedApprove
Delayed approval mechanism [FIXED JENKINS-11409]
Compare:
https://github.com/jenkinsci/gerrit-trigger-plugin/compare/3246d8e32d87...c512069db193
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
