Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/git-client-plugin
  Commit: 4e8ac18d3fe622bb7df4acca286706fa2d3d5365
      
https://github.com/jenkinsci/git-client-plugin/commit/4e8ac18d3fe622bb7df4acca286706fa2d3d5365
  Author: Matt Moore <[email protected]>
  Date:   2014-02-19 (Wed, 19 Feb 2014)

  Changed paths:
    M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java

  Log Message:
  -----------
  tl;dr: s/UsernamePasswordCredentialsImpl/StandardUsernamePasswordCredentials/

NOTE: This is the same change that I had made previously in this pull request: 
https://github.com/jenkinsci/git-client-plugin/pull/32

I am not sure how or why my "merged" pull request does not appear in the commit 
history of the repo.

The original notes from PR#32 follow:

Weaken the type requirement on the instanceof used in the git-client plugin to 
only rely on the object being a StandardUsernamePasswordCredentials.

The interface is both necessary and sufficient for the APIs used.

This is morally equivalent to how the private key logic is already using the 
SSHUserPrivateKey interface vs. a specific implementation.


  Commit: 68284a0f3f85de3b0f9b12d1be9ffa11286ea4a0
      
https://github.com/jenkinsci/git-client-plugin/commit/68284a0f3f85de3b0f9b12d1be9ffa11286ea4a0
  Author: Nicolas De loof <[email protected]>
  Date:   2014-02-19 (Wed, 19 Feb 2014)

  Changed paths:
    M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java

  Log Message:
  -----------
  Merge pull request #115 from mattmoor/master

tl;dr: s/UsernamePasswordCredentialsImpl/StandardUsernamePasswordCredentials/


Compare: 
https://github.com/jenkinsci/git-client-plugin/compare/6e581cda7339...68284a0f3f85

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to