Branch: refs/heads/master
Home: https://github.com/jenkinsci/maven-plugin
Commit: 724f982fec81c2b49516e95ac00e5b754cb679ed
https://github.com/jenkinsci/maven-plugin/commit/724f982fec81c2b49516e95ac00e5b754cb679ed
Author: James Nord <[email protected]>
Date: 2022-05-12 (Thu, 12 May 2022)
Changed paths:
M src/test/java/hudson/model/NodeTest.java
Log Message:
-----------
create agents with labels pre-set (#267)
calling setLabels on an agent will not persist the node.
in older versions of Jenkins the tests would be less flaky as adding any
Node would cause all labels to be re-evaluated, so when creating a few
agents and adding labels in a loop the last one created would at least
deterministically ensure that all previous agents labels where correct.
However since 2.332 (jenkinsci/jenkins#5882)
only labels part of a node added or removed would be updated, and when
creating the agents they where created without labels, which where added
later.
This caused tests to be flaky depending on when the periodic
trimLabels was called (or at least on other timing related things)
Additionally creating agents and waiting for them to come oneline is
slow. A job can be scheduled and will then wait for the node to be available,
so we can do other things whilst the agent is connecting.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/maven-plugin/push/refs/heads/master/a4b762-724f98%40github.com.
