Branch: refs/heads/master

  Home:   https://github.com/jenkinsci/jobcacher-plugin

  Commit: 054a5cebffaf228cec6ef59dd01adf1e003ac882

      
https://github.com/jenkinsci/jobcacher-plugin/commit/054a5cebffaf228cec6ef59dd01adf1e003ac882

  Author: René Scheibe <[email protected]>

  Date:   2022-06-12 (Sun, 12 Jun 2022)



  Changed paths:

    M src/main/java/jenkins/plugins/itemstorage/local/LocalObjectPath.java

    M src/main/java/jenkins/plugins/itemstorage/s3/Downloads.java

    M src/main/java/jenkins/plugins/itemstorage/s3/NonAWSS3ItemStorage.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3Callable.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3DownloadAllCallable.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3ItemStorage.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3UploadAllCallable.java

    M src/main/java/jenkins/plugins/jobcacher/CacheBuildLastAction.java

    M src/main/java/jenkins/plugins/jobcacher/CacheManager.java

    M src/main/java/jenkins/plugins/jobcacher/CacheProjectAction.java

    M src/main/java/jenkins/plugins/jobcacher/CacheWrapper.java

    M src/main/java/jenkins/plugins/jobcacher/pipeline/CacheStep.java



  Log Message:

  -----------

  Make fields final where useful



This increases immutability which can reduce the probability of bugs.





  Commit: e623135e0a3d8e47a4257c800c1475b6d96f02e3

      
https://github.com/jenkinsci/jobcacher-plugin/commit/e623135e0a3d8e47a4257c800c1475b6d96f02e3

  Author: René Scheibe <[email protected]>

  Date:   2022-06-12 (Sun, 12 Jun 2022)



  Changed paths:

    M src/main/java/jenkins/plugins/itemstorage/local/LocalObjectPath.java

    M src/main/java/jenkins/plugins/itemstorage/s3/ClientHelper.java

    M src/main/java/jenkins/plugins/itemstorage/s3/Destination.java

    M src/main/java/jenkins/plugins/itemstorage/s3/NonAWSS3ItemStorage.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3BaseUploadCallable.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3ItemStorage.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3Profile.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3UploadAllCallable.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3UploadCallable.java

    M src/main/java/jenkins/plugins/itemstorage/s3/Uploads.java

    M src/main/java/jenkins/plugins/jobcacher/Cache.java



  Log Message:

  -----------

  Remove occasional uses of "final" from method signatures and bodies



Here the scope and impact is pretty limited and using `final` is more noisy 
than useful here.





  Commit: a28678bda67e96a818ab09772f75d5f09525bd46

      
https://github.com/jenkinsci/jobcacher-plugin/commit/a28678bda67e96a818ab09772f75d5f09525bd46

  Author: René Scheibe <[email protected]>

  Date:   2022-06-12 (Sun, 12 Jun 2022)



  Changed paths:

    M 
src/test/java/jenkins/plugins/jobcacher/ArbitraryFileCachePipelineTest.java



  Log Message:

  -----------

  Reduce mutability in tests





  Commit: be8aac95c8bc970462c7a4c5cba35540c17acad4

      
https://github.com/jenkinsci/jobcacher-plugin/commit/be8aac95c8bc970462c7a4c5cba35540c17acad4

  Author: repolevedavaj <[email protected]>

  Date:   2022-06-13 (Mon, 13 Jun 2022)



  Changed paths:

    M src/main/java/jenkins/plugins/itemstorage/local/LocalObjectPath.java

    M src/main/java/jenkins/plugins/itemstorage/s3/ClientHelper.java

    M src/main/java/jenkins/plugins/itemstorage/s3/Destination.java

    M src/main/java/jenkins/plugins/itemstorage/s3/Downloads.java

    M src/main/java/jenkins/plugins/itemstorage/s3/NonAWSS3ItemStorage.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3BaseUploadCallable.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3Callable.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3DownloadAllCallable.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3ItemStorage.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3Profile.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3UploadAllCallable.java

    M src/main/java/jenkins/plugins/itemstorage/s3/S3UploadCallable.java

    M src/main/java/jenkins/plugins/itemstorage/s3/Uploads.java

    M src/main/java/jenkins/plugins/jobcacher/Cache.java

    M src/main/java/jenkins/plugins/jobcacher/CacheBuildLastAction.java

    M src/main/java/jenkins/plugins/jobcacher/CacheManager.java

    M src/main/java/jenkins/plugins/jobcacher/CacheProjectAction.java

    M src/main/java/jenkins/plugins/jobcacher/CacheWrapper.java

    M src/main/java/jenkins/plugins/jobcacher/pipeline/CacheStep.java

    M 
src/test/java/jenkins/plugins/jobcacher/ArbitraryFileCachePipelineTest.java



  Log Message:

  -----------

  Merge pull request #31 from darxriggs/immutability



Improve Immutability





Compare: 
https://github.com/jenkinsci/jobcacher-plugin/compare/555eaf9556ec...be8aac95c8bc

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/jobcacher-plugin/push/refs/heads/master/555eaf-be8aac%40github.com.

Reply via email to