Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/remoting
  Commit: e7706e14eb7d03680fc7dfac6df7f315092a9eed
      
https://github.com/jenkinsci/remoting/commit/e7706e14eb7d03680fc7dfac6df7f315092a9eed
  Author: Vincent Latombe <[email protected]>
  Date:   2022-11-29 (Tue, 29 Nov 2022)

  Changed paths:
    M pom.xml
    R src/test/java/Driver8703.java
    M src/test/java/hudson/remoting/AbstractNioChannelRunner.java
    M src/test/java/hudson/remoting/BinarySafeStreamTest.java
    M src/test/java/hudson/remoting/ChannelFilterTest.java
    M src/test/java/hudson/remoting/ChannelRunner.java
    A src/test/java/hudson/remoting/ChannelRunners.java
    M src/test/java/hudson/remoting/ChannelTest.java
    R src/test/java/hudson/remoting/ChannelTestSuite.java
    M src/test/java/hudson/remoting/ClassRemoting2Test.java
    M src/test/java/hudson/remoting/ClassRemotingTest.java
    M src/test/java/hudson/remoting/DeadRemoteOutputStreamTest.java
    M src/test/java/hudson/remoting/DummyClassLoaderTest.java
    M src/test/java/hudson/remoting/ExportTableTest.java
    M src/test/java/hudson/remoting/ForkRunner.java
    M src/test/java/hudson/remoting/HexDumpTest.java
    M src/test/java/hudson/remoting/InProcessRunner.java
    M src/test/java/hudson/remoting/NonSerializableExceptionTest.java
    M src/test/java/hudson/remoting/PipeTest.java
    M src/test/java/hudson/remoting/PipeWriterTest.java
    M src/test/java/hudson/remoting/PrefetchTest.java
    M src/test/java/hudson/remoting/PrefetchingTest.java
    M src/test/java/hudson/remoting/ProxyWriterTest.java
    M src/test/java/hudson/remoting/RemoteInputStreamTest.java
    M src/test/java/hudson/remoting/RemoteInvocationHandlerTest.java
    R src/test/java/hudson/remoting/RmiTestBase.java
    M src/test/java/hudson/remoting/SimpleTest.java

  Log Message:
  -----------
  Support junit 5; Migrate non-forked junit 3 test cases (#593)

* Support junit 5; Migrate non-forked junit 3 test cases

Migrate existing junit 3 tests to junit 5 with standard ParameterizedTest 
facility

This uses @MethodSource providing the various ChannelRunner instances
used for testing.

Migrated existing assert/assume calls impacted tests to the new jupiter api.

Overall this covers more combinations than the previous framework as
some of them were actually not covered previously for some reason.

Keeping existing junit 3 test cases from forked packages as the proper
approach here would rather be to pull new versions.

* Fix PrefetchingTest#testJarLoadingTest

* Restore lost comment

* Unused import

* use hamcrest

* Always use the same assertArrayEquals

* Update src/test/java/hudson/remoting/ChannelRunners.java

Co-authored-by: Jesse Glick <[email protected]>

* Set a timeout on ChannelTest

* Apply a more aggressive and general timeout to all JUnit 5 tests

* typo

Co-authored-by: Jesse Glick <[email protected]>


-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/remoting/push/refs/heads/master/bdecda-e7706e%40github.com.

Reply via email to