Branch: refs/heads/master
Home: https://github.com/jenkinsci/git-plugin
Commit: 9fcc996aad343b750feba2b87053c6fbb5b24318
https://github.com/jenkinsci/git-plugin/commit/9fcc996aad343b750feba2b87053c6fbb5b24318
Author: Mark Waite <[email protected]>
Date: 2022-12-12 (Mon, 12 Dec 2022)
Changed paths:
R src/main/resources/hudson/plugins/git/UserRemoteConfig/config.groovy
A src/main/resources/hudson/plugins/git/UserRemoteConfig/config.jelly
Log Message:
-----------
Remove credentials "Add" button workaround (#1374)
* [JENKINS-70215] Remove bad credentials button markup
https://issues.jenkins.io/browse/JENKINS-70215 reports that the "Add
credentials" button has unexpected lines drawn inside the button on
Google Chrome. The position of the lines inside the button seem to
depend on the location of the position of the button on the screen.
https://issues.jenkins.io/browse/JENKINS-19124 was listed in the
comments as the reason for the embedded JavaScript code in that button
definition. The Mercurial plugin does not use that JavaScript code in
its credentials button. It seems safe to remove it from the git
plugin "Add" button for credentials.
Interactive testing before the change confirmed that the unexpected
line(s) were drawn inside the button. Interactive testing after the
change confirmed that the unexpected line(s) were no longer being
drawn inside the button.
* Replace groovy form with jelly
Much more attention is being given to jelly forms than to groovy forms.
Replace the groovy form with a jelly form because it is better for the
future of the plugin. This is a behavior preserving transformation,
expected to cause no change in behavior.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/git-plugin/push/refs/heads/master/c3da01-9fcc99%40github.com.
