Branch: refs/heads/master
Home: https://github.com/jenkinsci/git-plugin
Commit: 7968e3f38cdcaab582ccf61ca49bf85ed3da728c
https://github.com/jenkinsci/git-plugin/commit/7968e3f38cdcaab582ccf61ca49bf85ed3da728c
Author: Erik Müller <[email protected]>
Date: 2023-07-11 (Tue, 11 Jul 2023)
Changed paths:
M src/main/java/jenkins/plugins/git/GitUsernamePasswordBinding.java
M src/test/java/jenkins/plugins/git/GitUsernamePasswordBindingTest.java
Log Message:
-----------
Escape special characters for GitUsernamePasswordBinding in withCrede… (#1443)
* Escape special characters for GitUsernamePasswordBinding in withCredentials
* Fix test for GitUsernamePasswordBinding in withCredentials
* Adapt writing ASKPASS from git-client-plugin
* Fix tests
* Reduce diffs by retaining old, ugly formatting of comment
In the future, the repository will be formatted with spotless and that
ugliness will be banished forever. Helps my code review to make the
diffs small now.
* Make filename encoding methods private
No need to make them visible outside the class where they are used.
Also adds the same comment on these methods as is used on the methods
in the git client plugin so that future consumers will know to not use
them for any other purpose than their current very limited use.
* Add more sample passwords
* Move assertions into existing conditional
---------
Co-authored-by: Mark Waite <[email protected]>
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/git-plugin/push/refs/heads/master/c75dea-7968e3%40github.com.
