Branch: refs/heads/master
Home: https://github.com/jenkinsci/jenkins
Commit: 873de8cd22738150e49bd8cda0d0b510b554fa7d
https://github.com/jenkinsci/jenkins/commit/873de8cd22738150e49bd8cda0d0b510b554fa7d
Author: Matt Moore <[email protected]>
Date: 2014-09-28 (Sun, 28 Sep 2014)
Changed paths:
M core/src/main/java/hudson/model/AbstractProject.java
Log Message:
-----------
Switch the source of a number of AbstractProject config options from
StaplerRequest to JSONObject.
This change shifts the way a number of form elements are accessed when handling
AbstractProject's doConfigSubmit from using "req.getParameter(...)" style
access to using JSON-style (structured form submission) access through
"reg.getSubmittedForm()".
Commit: 86c911e8b9ba31cef77a7cf44179017dc9dc35db
https://github.com/jenkinsci/jenkins/commit/86c911e8b9ba31cef77a7cf44179017dc9dc35db
Author: Matt Moore <[email protected]>
Date: 2014-09-28 (Sun, 28 Sep 2014)
Changed paths:
M core/src/main/java/hudson/model/AbstractProject.java
M
core/src/main/resources/lib/hudson/project/config-blockWhenDownstreamBuilding.jelly
M
core/src/main/resources/lib/hudson/project/config-blockWhenUpstreamBuilding.jelly
M core/src/main/resources/lib/hudson/project/config-concurrentBuild.jelly
M core/src/main/resources/lib/hudson/project/config-disableBuild.jelly
Log Message:
-----------
Switch to using inline optionalBlock for several AbstractProject checkboxes
so that we are passed a boolean, instead of either null or {}.
NOTE: The discrepancy between inline-optionalBlock and f:entry/f:checkbox is
the text alignment, which optionalBlock keeps consistent with other elements
(and what is done for these today).
Commit: eec43983a3bdfce6de45ca0559d8a9f8a1250b71
https://github.com/jenkinsci/jenkins/commit/eec43983a3bdfce6de45ca0559d8a9f8a1250b71
Author: Matt Moore <[email protected]>
Date: 2014-09-29 (Mon, 29 Sep 2014)
Changed paths:
M core/src/main/java/hudson/model/AbstractProject.java
M core/src/main/resources/lib/hudson/project/config-assignedLabel.jelly
M core/src/main/resources/lib/hudson/project/config-customWorkspace.jelly
M core/src/main/resources/lib/hudson/project/config-quietPeriod.jelly
M core/src/main/resources/lib/hudson/project/config-retryCount.jelly
M test/src/test/java/hudson/model/labels/LabelExpressionTest.java
Log Message:
-----------
This change converts several optionalBlock's wrapping a single field to
inline="true".
By converting several optionalBlock entries to use inline="true", we convert
the submitted JSON from:
"hasPropertyFoo": {
"propertyFoo": "value"
},
which is a somewhat unnatural naming scheme, to:
"hasPropertyFoo": true,
"propertyFoo": "value",
This enables us to use the pattern:
if(json.optBoolean("hasPropertyFoo", json.has("propertyFoo"))) {
...
}
To permit either of the following as JSON blobs, for specifying a value for
"propertyFoo":
1) "hasPropertyFoo": true, # What comes through from jelly
"propertyFoo": "value",
2) "propertyFoo": "value",
It also allows any of the following as JSON blobs, for NOT specifying a value
for "propertyFoo":
3) "hasPropertyFoo": false, # What comes through from jelly
"propertyFoo": "value",
4) "hasPropertyFoo": false,
5) (nothing specified)
NOTE: The main interest in flexibility in what JSON comes through is in support
of: https://wiki.jenkins-ci.org/display/JENKINS/YAML+Project+Plugin, this is
also the purpose of the couple renames that are mixed in with this.
Commit: c8b6f127843632e4ee617570581ef64a67ac18c6
https://github.com/jenkinsci/jenkins/commit/c8b6f127843632e4ee617570581ef64a67ac18c6
Author: Jesse Glick <[email protected]>
Date: 2014-10-08 (Wed, 08 Oct 2014)
Changed paths:
M core/src/main/java/hudson/model/AbstractProject.java
M core/src/main/resources/lib/hudson/project/config-assignedLabel.jelly
M
core/src/main/resources/lib/hudson/project/config-blockWhenDownstreamBuilding.jelly
M
core/src/main/resources/lib/hudson/project/config-blockWhenUpstreamBuilding.jelly
M core/src/main/resources/lib/hudson/project/config-concurrentBuild.jelly
M core/src/main/resources/lib/hudson/project/config-customWorkspace.jelly
M core/src/main/resources/lib/hudson/project/config-disableBuild.jelly
M core/src/main/resources/lib/hudson/project/config-quietPeriod.jelly
M core/src/main/resources/lib/hudson/project/config-retryCount.jelly
M test/src/test/java/hudson/model/labels/LabelExpressionTest.java
Log Message:
-----------
Merge pull request #1414 from mattmoor/master
Convert AbstractProject to better utilize structure form submission.
Compare:
https://github.com/jenkinsci/jenkins/compare/0adf979c4a3f...c8b6f1278436
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
