Branch: refs/heads/JENKINS-23152 Home: https://github.com/jenkinsci/gerrit-trigger-plugin Commit: e4421a56cb90c88736e83fe05c3d57d752acf45c https://github.com/jenkinsci/gerrit-trigger-plugin/commit/e4421a56cb90c88736e83fe05c3d57d752acf45c Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-05-22 (Thu, 22 May 2014)
Changed paths: M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/spec/SpecGerritTriggerHudsonTest.java Log Message: ----------- Reproduced problem in test: old copy of project is still referenced (see below); and second build is not run but not found. private static com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTriggerTimer com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTriggerTimer.instance-> com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTriggerTimer@54f3e538-timer-> java.util.Timer@692dff13-queue-> java.util.TaskQueue@548b26c6-queue-> [Ljava.util.TimerTask;@729e2285-[2]-> com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTriggerTimerTask@7c6dae73-gerritTrigger-> com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger@3248ded0-myProject-> hudson.model.FreeStyleProject@39913454 Commit: c98d09bb10b9887ca800a24791ca7827ffb9fe4f https://github.com/jenkinsci/gerrit-trigger-plugin/commit/c98d09bb10b9887ca800a24791ca7827ffb9fe4f Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-05-22 (Thu, 22 May 2014) Changed paths: M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java Log Message: ----------- myProject field is redundant when Trigger.job already exists. Commit: e4a084e23adcd7ab16a2866d2e24107b18483b62 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/e4a084e23adcd7ab16a2866d2e24107b18483b62 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-05-22 (Thu, 22 May 2014) Changed paths: M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimerTask.java Log Message: ----------- Progress. New leak: private static com.sonyericsson.hudson.plugins.gerrit.trigger.PluginImpl com.sonyericsson.hudson.plugins.gerrit.trigger.PluginImpl.instance-> com.sonyericsson.hudson.plugins.gerrit.trigger.PluginImpl@75a69570-gerritEventManager-> com.sonyericsson.hudson.plugins.gerrit.trigger.GerritHandlerLifecycle@5d4a7b45-gerritEventListeners-> java.util.concurrent.CopyOnWriteArraySet@3579f74a-al-> java.util.concurrent.CopyOnWriteArrayList@11103fa6-array-> [Ljava.lang.Object;@73bcafa1-[2]-> com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger@10642995-job-> hudson.model.FreeStyleProject@63dd2ec Commit: f40ec4e175b32bed99c7d993b1132fe34701879b https://github.com/jenkinsci/gerrit-trigger-plugin/commit/f40ec4e175b32bed99c7d993b1132fe34701879b Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-05-22 (Thu, 22 May 2014) Changed paths: M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java Log Message: ----------- Moving right along. Now getting: private static com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener.instance-> com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.ToGerritRunListener@7127c1a1-memory-> com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.model.BuildMemory@4cbf8111-memory-> java.util.TreeMap@26f10c06-root-> java.util.TreeMap$Entry@568b866f-value-> com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.model.BuildMemory$MemoryImprint@4ab70a17-list-> java.util.ArrayList@28967588-elementData-> [Ljava.lang.Object;@3c9b3ade-[0]-> com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.model.BuildMemory$MemoryImprint$Entry@23ac0ff5-project-> hudson.model.FreeStyleProject@3f5c583e Commit: dcc1f4136d2515241156eadc886e69f8bb75c365 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/dcc1f4136d2515241156eadc886e69f8bb75c365 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-05-22 (Thu, 22 May 2014) Changed paths: M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java Log Message: ----------- Down to something that looks more like a test artifact than anything else. private static org.jvnet.hudson.test.TestEnvironment org.jvnet.hudson.test.TestEnvironment.CURRENT-> org.jvnet.hudson.test.TestEnvironment@637edfa7-testCase-> com.sonyericsson.hudson.plugins.gerrit.trigger.spec.SpecGerritTriggerHudsonTest@52c74dec-server-> org.mortbay.jetty.Server@5c420b3d-_sessionIdManager-> org.mortbay.jetty.servlet.HashSessionIdManager@ed5f6a8-_sessions-> org.mortbay.util.MultiMap@376ca809-table-> [Ljava.util.HashMap$Entry;@6dee3245-[8]-> java.util.HashMap$Entry@2e3e2c34-value-> org.mortbay.jetty.servlet.HashSessionManager$Session@78cd92a2-_values-> java.util.HashMap@4a7e47af-table-> [Ljava.util.HashMap$Entry;@647d7bd5-[2]-> java.util.HashMap$Entry@51b14c9-value-> org.kohsuke.stapler.bind.BoundObjectTable$Table@46ae9e11-entries-> java.util.HashMap@26724211-table-> [Ljava.util.HashMap$Entry;@3600505a-[9]-> java.util.HashMap$Entry@25660079-value-> org.kohsuke.stapler.bind.BoundObjectTable$StrongRef@70c97fa5-o-> hudson.widgets.RenderOnDemandClosure@4283613-variables-> hudson.util.PackedMap@62b6b956-kvpairs-> [Ljava.lang.Object;@5d630352-[1]-> hudson.model.FreeStyleProject@61b65bb0 Commit: d91ec65908458cc02fb99ecaa33c2bd69775d6e4 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/d91ec65908458cc02fb99ecaa33c2bd69775d6e4 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-05-22 (Thu, 22 May 2014) Changed paths: M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/spec/SpecGerritTriggerHudsonTest.java Log Message: ----------- Test still failing (and heap walker broken) and still have old instance in memory, yet bug no longer reproducible live. hprof heap walk shows this root ref: this - value: hudson.model.FreeStyleProject #1 <- project - class: com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.TriggeredItemEntity, value: hudson.model.FreeStyleProject #1 <- item - class: java.util.LinkedList$Node, value: com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.TriggeredItemEntity #1 <- last - class: java.util.LinkedList, value: java.util.LinkedList$Node #1237 <- builds - class: com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.actions.manual.TriggerMonitor$EventState, value: java.util.LinkedList #278 <- item - class: java.util.LinkedList$Node, value: com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.actions.manual.TriggerMonitor$EventState #1 <- last - class: java.util.LinkedList, value: java.util.LinkedList$Node #1236 <- events - class: com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.actions.manual.TriggerMonitor, value: java.util.LinkedList #276 <- value - class: java.util.HashMap$Entry, value: com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.actions.manual.TriggerMonitor #1 <- [0] - class: java.util.HashMap$Entry[], value: java.util.HashMap$Entry #71453 <- table - class: java.util.HashMap, value: java.util.HashMap$Entry[] #22502 <- _values - class: org.mortbay.jetty.servlet.HashSessionManager$Session, value: java.util.HashMap #24894 <- value - class: java.util.HashMap$Entry, value: org.mortbay.jetty.servlet.HashSessionManager$Session #1 <- [15] - class: java.util.HashMap$Entry[], value: java.util.HashMap$Entry #60508 <- table - class: java.util.HashMap, value: java.util.HashMap$Entry[] #19294 <- _sessions - class: org.mortbay.jetty.servlet.HashSessionManager, value: java.util.HashMap #16704 <- this$0 (Java frame) - class: org.mortbay.jetty.servlet.HashSessionManager$SessionScavenger, value: org.mortbay.jetty.servlet.HashSessionManager #1 Commit: 866a0df7ce218261e486ae922ef7594b9a7f0302 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/866a0df7ce218261e486ae922ef7594b9a7f0302 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-05-22 (Thu, 22 May 2014) Changed paths: M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java Log Message: ----------- Compilation fix. Commit: cfaea0fa9bb36e0b6b3686b52fa4f0992864e42c https://github.com/jenkinsci/gerrit-trigger-plugin/commit/cfaea0fa9bb36e0b6b3686b52fa4f0992864e42c Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-05-22 (Thu, 22 May 2014) Changed paths: M pom.xml Log Message: ----------- CheckStyle is complaining that GerritTrigger.java may be 2000 lines long, but not 2019?! Commit: 24c7b25dbf75925379480f0cbfda8903c0d336db https://github.com/jenkinsci/gerrit-trigger-plugin/commit/24c7b25dbf75925379480f0cbfda8903c0d336db Author: Robert Sandell <rsand...@cloudbees.com> Date: 2014-10-29 (Wed, 29 Oct 2014) Changed paths: M pom.xml M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimerTask.java M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/spec/SpecGerritTriggerHudsonTest.java Log Message: ----------- Merge branch 'reload-JENKINS-23152' of github.com:jglick/gerrit-trigger-plugin into JENKINS-23152 Conflicts: src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/spec/SpecGerritTriggerHudsonTest.java Commit: 046ee583b7ebcde67f295beb9dbadd39a2099a94 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/046ee583b7ebcde67f295beb9dbadd39a2099a94 Author: Robert Sandell <rsand...@cloudbees.com> Date: 2014-10-29 (Wed, 29 Oct 2014) Changed paths: M pom.xml Log Message: ----------- Revert "CheckStyle is complaining that GerritTrigger.java may be 2000 lines long, but not 2019?!" This reverts commit cfaea0fa9bb36e0b6b3686b52fa4f0992864e42c. Commit: c9dd5df122c7998cd3c97f02926df1654fe4fa57 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/c9dd5df122c7998cd3c97f02926df1654fe4fa57 Author: Robert Sandell <rsand...@cloudbees.com> Date: 2014-10-29 (Wed, 29 Oct 2014) Changed paths: M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/PluginImpl.java A src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java Log Message: ----------- Extract event listeners and scheduling to a separate class Commit: 1eb20e4ba5c25ed306fb4fd08e1f9d1dd4a9b6b8 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/1eb20e4ba5c25ed306fb4fd08e1f9d1dd4a9b6b8 Author: Robert Sandell <rsand...@cloudbees.com> Date: 2014-10-29 (Wed, 29 Oct 2014) Changed paths: M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimerTask.java M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/spec/SpecGerritTriggerHudsonTest.java Log Message: ----------- Checkstyle fixes Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/e4421a56cb90^...1eb20e4ba5c2 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.