Branch: refs/heads/master Home: https://github.com/jenkinsci/workflow-basic-steps-plugin Commit: 936b4007434c625df8cc1bb1ae91abe8dffad235 https://github.com/jenkinsci/workflow-basic-steps-plugin/commit/936b4007434c625df8cc1bb1ae91abe8dffad235 Author: Denys Digtiar <ddigt...@cloudbees.com> Date: 2024-03-05 (Tue, 05 Mar 2024)
Changed paths: M src/main/java/org/jenkinsci/plugins/workflow/steps/ToolStep.java M src/test/java/org/jenkinsci/plugins/workflow/steps/ToolStepTest.java Log Message: ----------- JENKINS-61474 Improve null safety of tool step Tools page doesn't prevent submission of empty tool names. Some tools (e.g. Allure Commandline) use `Util.fixEmptyAndTrim` on the name, so there is a possibility of NPE when comparing the tool names. By flipping the comparison we avoid NPE since `tool` step requires `name` argument. Commit: 257ae6b30fbd0bbbc59a2d30f87f9f6fd5e5db91 https://github.com/jenkinsci/workflow-basic-steps-plugin/commit/257ae6b30fbd0bbbc59a2d30f87f9f6fd5e5db91 Author: James Nord <jtn...@users.noreply.github.com> Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M src/main/java/org/jenkinsci/plugins/workflow/steps/ToolStep.java M src/test/java/org/jenkinsci/plugins/workflow/steps/ToolStepTest.java Log Message: ----------- Merge pull request #302 from duemir/JENKINS-61474 JENKINS-61474 Improve null safety of the tool step Compare: https://github.com/jenkinsci/workflow-basic-steps-plugin/compare/2e7111ae4194...257ae6b30fbd To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/workflow-basic-steps-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/workflow-basic-steps-plugin/push/refs/heads/master/2e7111-257ae6%40github.com.