Branch: refs/heads/master
Home: https://github.com/jenkinsci/jenkins
Commit: 16b5d210525f1e0b31d15b6cf4a06c291099e049
https://github.com/jenkinsci/jenkins/commit/16b5d210525f1e0b31d15b6cf4a06c291099e049
Author: Jakob Ackermann <das7...@outlook.com>
Date: 2024-06-18 (Tue, 18 Jun 2024)
Changed paths:
M core/src/main/java/hudson/slaves/CloudRetentionStrategy.java
M core/src/main/java/hudson/slaves/CloudSlaveRetentionStrategy.java
M core/src/main/java/hudson/slaves/ComputerRetentionWork.java
M core/src/main/java/hudson/slaves/RetentionStrategy.java
M core/src/main/java/hudson/slaves/SimpleScheduledRetentionStrategy.java
A
core/src/main/java/jenkins/model/GlobalComputerRetentionCheckIntervalConfiguration.java
A
core/src/main/resources/jenkins/model/GlobalComputerRetentionCheckIntervalConfiguration/config.jelly
A
test/src/test/java/jenkins/model/GlobalComputerRetentionCheckIntervalConfigurationTest.java
A war/src/main/webapp/help/system-config/computerRetentionCheckInterval.html
Log Message:
-----------
[JENKINS-14789] Configurable interval for computer retention check (#7037)
* [JENKINS-14789] Configurable interval for computer retention check
Also update the lower bound delay as returned by each RetentionStrategy
from 1min to 0min. This is enabling check intervals of <1min to trigger
a re-check in the next cycle (previously, the nextCheck tracking would
defer the next re-check into the 2nd cycle -- one for the timer loop
and once for the nextCheck timestamp).
Includes a bug fix:
`CloudSlaveRetentionStrategy` tracks the agent timeout in milliseconds
internally and returned the nextCheck delay as a tenth of that.
The nextCheck delay is consumed in minutes, leading to the max delay
of one hour being used.
Fix: Convert the delay from milliseconds to minutes.
Signed-off-by: Jakob Ackermann <das7...@outlook.com>
* [JENKINS-14789] Allow a check interval of one second
Signed-off-by: Jakob Ackermann <das7...@outlook.com>
* [JENKINS-14789] Apply review feedback
- Double down on JavaDoc
- Migrate UI to jelly
Co-Authored-By: Alexander Brandes <mc.ca...@web.de>
Signed-off-by: Jakob Ackermann <das7...@outlook.com>
* [JENKINS-14789] Store computerRetentionCheckInterval in model instance
Signed-off-by: Jakob Ackermann <das7...@outlook.com>
* [JENKINS-14789] Add missing javadoc comment
Signed-off-by: Jakob Ackermann <das7...@outlook.com>
* [JENKINS-14789] Add tests for model
Signed-off-by: Jakob Ackermann <das7...@outlook.com>
* [JENKINS-14789] Use AperiodicWork for ComputerRetentionWork
Signed-off-by: Jakob Ackermann <das7...@outlook.com>
* [JENKINS-14789] limit computer retention check interval to 60s
Signed-off-by: Jakob Ackermann <das7...@outlook.com>
* [JENKINS-14789] apply review feedback
Co-authored-by: Tim Jacomb <21194782+ti...@users.noreply.github.com>
Signed-off-by: Jakob Ackermann <das7...@outlook.com>
---------
Signed-off-by: Jakob Ackermann <das7...@outlook.com>
Co-authored-by: Alexander Brandes <mc.ca...@web.de>
Co-authored-by: Tim Jacomb <21194782+ti...@users.noreply.github.com>
To unsubscribe from these emails, change your notification settings at
https://github.com/jenkinsci/jenkins/settings/notifications
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/jenkins/push/refs/heads/master/048743-16b5d2%40github.com.
