Branch: refs/heads/master
Home: https://github.com/jenkinsci/nodelabelparameter-plugin
Commit: 990c04ca7a12583ce43c789ff6487f7d758cf7ad
https://github.com/jenkinsci/nodelabelparameter-plugin/commit/990c04ca7a12583ce43c789ff6487f7d758cf7ad
Author: Tamaghna Chattopadhyay
<[email protected]>
Date: 2024-12-21 (Sat, 21 Dec 2024)
Changed paths:
M
src/test/java/org/jvnet/jenkins/plugins/nodelabelparameter/parameterizedtrigger/NodeLabelBuildParameterTest.java
Log Message:
-----------
Improve Automated Test Coverage (#366)
* MacroEvaluationException-Test-Added
Signed-off-by: shinigami-777 <[email protected]>
* made-changes
Signed-off-by: shinigami-777 <[email protected]>
* resolved-errors
* minor-change
* minor-fix
* Update NodeLabelBuildParameter.java
* Simplify the node label token macro expression, but still fail
Simpler expression fails evaluation without embedded newlines
* Use a non-deprecated StreamTaskListener constructor
* Run the build and assert that it passed before testing build result
Running the build and asserting that it was successful provides a
workspace and tests a little more of the code than if we construct a
build ourselves.
* Use hamcrest matchers to check more conditions
The hamcrest matchers provide clearer error messages when an assertion
fails. The clearer error message makes it easier to diagnose failures.
The earlier change to run the build and wait for it to complete
successfully also changed the details of the exception being thrown.
Assert that the expected exception message is found in the log.
---------
Signed-off-by: shinigami-777 <[email protected]>
Co-authored-by: Mark Waite <[email protected]>
To unsubscribe from these emails, change your notification settings at
https://github.com/jenkinsci/nodelabelparameter-plugin/settings/notifications
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/nodelabelparameter-plugin/push/refs/heads/master/3b5c69-990c04%40github.com.
