Branch: refs/heads/master
Home: https://github.com/jenkinsci/jenkins
Commit: 5880ed830201f9349ae9def6653c19a186e1eb18
https://github.com/jenkinsci/jenkins/commit/5880ed830201f9349ae9def6653c19a186e1eb18
Author: Stephen Connolly <[email protected]>
Date: 2015-04-13 (Mon, 13 Apr 2015)
Changed paths:
M core/src/main/java/hudson/model/Queue.java
Log Message:
-----------
[FIXED JENKINS-27708][FIXED JENKINS-27871] Ensure that identification of
blocked tasks is using the live state.
- The creation of a snapshot itself should be relatively cheap given the
expected rate of
job execution. You probably would need 100's of jobs starting execution every
iteration
of maintain() before this could even start to become an issue and likely the
calculation
of isBuildBlocked(p) will become a bottleneck before updateSnapshot() will.
Additionally
since the snapshot itself only ever has at most one reference originating
outside of the stack
it should remain in the eden space and thus be cheap to GC.
- JENKINS-27708 comments 225819 and 225906 provide more complex but logically
equivalent fixes of
this issue. I am favouring this approach as it is simpler and provides less
scope for error as any
new helper methods can just rely on the snapshot being up to date whereas
with the other
two candidates if a new helper method is introduced there is the potential to
miss adding support
for the live view. The comment 225819 has the risk of introducing extra lock
contention while
the comment 225906 version forces every access to the helper methods to pass
a second memory
barrier
Commit: 7514e8c6ce35283da4a8bb4422fe885350fc8681
https://github.com/jenkinsci/jenkins/commit/7514e8c6ce35283da4a8bb4422fe885350fc8681
Author: Oleg Nenashev <[email protected]>
Date: 2015-04-14 (Tue, 14 Apr 2015)
Changed paths:
M test/src/test/java/hudson/model/QueueTest.java
Log Message:
-----------
[JENKINS-27871] - Added a direct unit test for the issue
Commit: 57efbea3d0326f8b24bbe458fa1d25f6f45589f8
https://github.com/jenkinsci/jenkins/commit/57efbea3d0326f8b24bbe458fa1d25f6f45589f8
Author: Stephen Connolly <[email protected]>
Date: 2015-04-14 (Tue, 14 Apr 2015)
Changed paths:
M test/src/test/java/hudson/model/QueueTest.java
Log Message:
-----------
Merge pull request #2 from oleg-nenashev/JENKINS-27871
[JENKINS-27871] - Added a direct unit test for the issue
Commit: 152d00ad09931c10f02fab4ac8a42e574d622bd3
https://github.com/jenkinsci/jenkins/commit/152d00ad09931c10f02fab4ac8a42e574d622bd3
Author: Stephen Connolly <[email protected]>
Date: 2015-04-15 (Wed, 15 Apr 2015)
Changed paths:
M core/src/main/java/hudson/model/Queue.java
M test/src/test/java/hudson/model/QueueTest.java
Log Message:
-----------
Merge pull request #1645 from stephenc/jenkins-27708
JENKINS-27708, JENKINS-27871 Ensure that identification of blocked tasks is
using the live state.
Compare:
https://github.com/jenkinsci/jenkins/compare/b688047877cf...152d00ad0993
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
