Branch: refs/heads/master
Home: https://github.com/jenkinsci/jenkins
Commit: de87736795898e57f7aca140124c2b1a3d1daf40
https://github.com/jenkinsci/jenkins/commit/de87736795898e57f7aca140124c2b1a3d1daf40
Author: Stephen Connolly <[email protected]>
Date: 2015-06-17 (Wed, 17 Jun 2015)
Changed paths:
M core/src/main/java/hudson/model/Queue.java
M core/src/main/java/hudson/model/queue/QueueSorter.java
Log Message:
-----------
[FIXED JENKINS-28926] Block while upstream/downstream building cycles never
complete
- One could argue that without this change the system is functioning correctly
and that previous behaviour
was a bug. On the other hand, people have come to rely on the previous
behaviour.
- The issue really centeres around state changes in the blocked tasks. Since
blocking on upstream/downstream
relies on checking the building projects and the queued (excluding blocked)
tasks we need any change in
the blocked task list to be visible immediately (i.e. update the snapshot)
- I was able to reliably reproduce this behaviour with a convoluted set of
manually configured projects
but turning this into a test case has not proved quite as easy. Manual
testing confirms that the issue is
fixed for my manual test case
- I have also added a sorting of the blocked list when probing for tasks to
unblock. This should prioritise
tasks as intended by the QueueSorter
Commit: c44c088442e1821f8cd44f4fdaa146d94dd85910
https://github.com/jenkinsci/jenkins/commit/c44c088442e1821f8cd44f4fdaa146d94dd85910
Author: Stephen Connolly <[email protected]>
Date: 2015-06-17 (Wed, 17 Jun 2015)
Changed paths:
M test/src/test/java/hudson/model/QueueTest.java
Log Message:
-----------
[JENKINS-28926] Adding test case
- I was forgetting the call to `rebuildDependencyGraph()` which was why the
test didn't work for me
Commit: 7929412037ff75f60791cfb23631521f8726c23d
https://github.com/jenkinsci/jenkins/commit/7929412037ff75f60791cfb23631521f8726c23d
Author: Stephen Connolly <[email protected]>
Date: 2015-06-17 (Wed, 17 Jun 2015)
Changed paths:
M core/src/main/java/hudson/model/Queue.java
M core/src/main/java/hudson/model/queue/QueueSorter.java
M test/src/test/java/hudson/model/QueueTest.java
Log Message:
-----------
Merge pull request #1743 from stephenc/jenkins-28926
[FIXED JENKINS-28926] Block while upstream/downstream building cycles never
complete
Compare:
https://github.com/jenkinsci/jenkins/compare/482bffa9cb91...7929412037ff
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
