Branch: refs/heads/master
Home: https://github.com/jenkinsci/workflow-plugin
Commit: f568d5d25f989884e2d5794dc7696cd0b7bb21ec
https://github.com/jenkinsci/workflow-plugin/commit/f568d5d25f989884e2d5794dc7696cd0b7bb21ec
Author: Jesse Glick <[email protected]>
Date: 2015-07-27 (Mon, 27 Jul 2015)
Changed paths:
A
aggregator/src/test/java/org/jenkinsci/plugins/workflow/DynamicEnvironmentExpanderTest.java
Log Message:
-----------
Checking whether it is possible to have a block-scoped step change its state
in onResume. Currently, not.
Commit: f3bd68e870299c90055380e2e98ad1d76146da08
https://github.com/jenkinsci/workflow-plugin/commit/f3bd68e870299c90055380e2e98ad1d76146da08
Author: recena <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepTest.java
Log Message:
-----------
TimeoutStepTest has been reviewed to make sure onResume is not invoked
Commit: f6da5cbaa40ca0ff83fd509e7d71acbe0c38fa2a
https://github.com/jenkinsci/workflow-plugin/commit/f6da5cbaa40ca0ff83fd509e7d71acbe0c38fa2a
Author: Jesse Glick <[email protected]>
Date: 2015-07-28 (Tue, 28 Jul 2015)
Changed paths:
M CHANGES.md
Log Message:
-----------
Merge branch 'master' into StepExecutionIterator-JENKINS-26163
Commit: 76fee2dbd4ab83c27c0bdd4586a94e86e420764b
https://github.com/jenkinsci/workflow-plugin/commit/76fee2dbd4ab83c27c0bdd4586a94e86e420764b
Author: Jesse Glick <[email protected]>
Date: 2015-07-28 (Tue, 28 Jul 2015)
Changed paths:
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepTest.java
Log Message:
-----------
Merge commits from @recena into StepExecutionIterator-JENKINS-26163.
Commit: 146d56fd3443fa346af56022992e321ae6dbe59e
https://github.com/jenkinsci/workflow-plugin/commit/146d56fd3443fa346af56022992e321ae6dbe59e
Author: Jesse Glick <[email protected]>
Date: 2015-07-28 (Tue, 28 Jul 2015)
Changed paths:
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepTest.java
Log Message:
-----------
We expect ABORTED here, not FAILURE. See the basic (non-parallel) test.
Commit: 50c721ecd5e260410328cdfc35bdce0dbf3088f3
https://github.com/jenkinsci/workflow-plugin/commit/50c721ecd5e260410328cdfc35bdce0dbf3088f3
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepTest.java
Log Message:
-----------
Restoring comment accidentally deleted.
Commit: 0b457301d435601a2ce601a362532d9fb27f2b25
https://github.com/jenkinsci/workflow-plugin/commit/0b457301d435601a2ce601a362532d9fb27f2b25
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepTest.java
Log Message:
-----------
Simplifying test and making it run more quickly if it were to pass.
When it fails, it now just hits the test timeout.
Commit: af4e5a3b77e1f957c8990cb6969c826be4b70952
https://github.com/jenkinsci/workflow-plugin/commit/af4e5a3b77e1f957c8990cb6969c826be4b70952
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepTest.java
Log Message:
-----------
Oops, needed to specify SECONDS explicitly.
Commit: 82dc5b99ee0efdcfc2048351a52883dda749e373
https://github.com/jenkinsci/workflow-plugin/commit/82dc5b99ee0efdcfc2048351a52883dda749e373
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M
basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/TimeoutStep.java
M
basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepExecution.java
Log Message:
-----------
Serializing TimeoutStep itself did not actually work, it turns out.
Commit: 9fe7f7af92b95a9ef654c451cfa9eb53c0055d84
https://github.com/jenkinsci/workflow-plugin/commit/9fe7f7af92b95a9ef654c451cfa9eb53c0055d84
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/DynamicEnvironmentExpanderTest.java
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepTest.java
M api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java
M
api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
M cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
Log Message:
-----------
Adding a flag to getCurrentExecutions.
Making onResume be called also on block steps.
This allows timeouts to be applied after a restart.
Commit: 4419ec8376a59fce699b4cc63a17d25afb324eec
https://github.com/jenkinsci/workflow-plugin/commit/4419ec8376a59fce699b4cc63a17d25afb324eec
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M
basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepExecution.java
Log Message:
-----------
Noting deprecated API call.
Commit: a9321f899890f4c55e33dbd09ba498bacc3e47d5
https://github.com/jenkinsci/workflow-plugin/commit/a9321f899890f4c55e33dbd09ba498bacc3e47d5
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M
basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/PushdStep.java
M
basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java
M
cps/src/main/java/org/jenkinsci/plugins/workflow/cps/steps/LoadStepExecution.java
M
step-api/src/main/java/org/jenkinsci/plugins/workflow/steps/AbstractStepExecutionImpl.java
Log Message:
-----------
Finally figured out why sometimes plain @Inject worked but sometimes
@Inject(optional=true) was needed.
AbstractStepExecutionImpl.onResume was not getting called for block-scoped
steps in most cases,
so it was not trying to reinject members and bogus optional=false Step
injections were never tried.
Commit: e8d7216c06e230d15deca0bd84a039a4ff36944b
https://github.com/jenkinsci/workflow-plugin/commit/e8d7216c06e230d15deca0bd84a039a4ff36944b
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/WaitForConditionStepTest.java
M
basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/WaitForConditionStep.java
Log Message:
-----------
Finally able to test waitUntil behavior during restart, and guess what, it
was actually broken.
Commit: 20af35a04a92c839f0289ce339f1667167c8c4c6
https://github.com/jenkinsci/workflow-plugin/commit/20af35a04a92c839f0289ce339f1667167c8c4c6
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M CHANGES.md
Log Message:
-----------
[JENKINS-26163] Noting internal bug as well as known user-visible effects.
Commit: 9ea55241ffac9dc711946ef30a0138224723580e
https://github.com/jenkinsci/workflow-plugin/commit/9ea55241ffac9dc711946ef30a0138224723580e
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/DynamicEnvironmentExpanderTest.java
Log Message:
-----------
Proving that onResume may be used to make an EnvironmentExpander behave
differently.
Commit: 8a8953ea0de2dab60ea01f371d58dbda2538ce60
https://github.com/jenkinsci/workflow-plugin/commit/8a8953ea0de2dab60ea01f371d58dbda2538ce60
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M CHANGES.md
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/scm/GitStepRestartTest.java
M job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJob.java
M job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
Log Message:
-----------
Merge branch 'master' into StepExecutionIterator-JENKINS-26163
Conflicts:
CHANGES.md
Commit: 66057df50e1b81e7ef1800707a5e4ef25f7ecb10
https://github.com/jenkinsci/workflow-plugin/commit/66057df50e1b81e7ef1800707a5e4ef25f7ecb10
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
Log Message:
-----------
getCurrentExecutions should be empty, not an error, when the program is
complete.
Commit: c4912ca24da0567d6c5dfae8d65714836818c6b8
https://github.com/jenkinsci/workflow-plugin/commit/c4912ca24da0567d6c5dfae8d65714836818c6b8
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/CpsFlowExecutionTest.java
M api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java
M cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
Log Message:
-----------
Testing detailed behavior of getCurrentExecutions.
Commit: 095178902c4e13b6a875480fac7380300d82830d
https://github.com/jenkinsci/workflow-plugin/commit/095178902c4e13b6a875480fac7380300d82830d
Author: Jesse Glick <[email protected]>
Date: 2015-07-29 (Wed, 29 Jul 2015)
Changed paths:
M
basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/TimeoutStep.java
M
basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepExecution.java
Log Message:
-----------
I now know that merely adding optional=true suffices to fix the Guice error
involving TimeoutStep.
Commit: fb3e89a3126665cb909b4113f41a306c0fb56380
https://github.com/jenkinsci/workflow-plugin/commit/fb3e89a3126665cb909b4113f41a306c0fb56380
Author: Jesse Glick <[email protected]>
Date: 2015-07-30 (Thu, 30 Jul 2015)
Changed paths:
M CHANGES.md
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/CpsFlowExecutionTest.java
A
aggregator/src/test/java/org/jenkinsci/plugins/workflow/DynamicEnvironmentExpanderTest.java
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepTest.java
M
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/WaitForConditionStepTest.java
M api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java
M
api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
M
basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/PushdStep.java
M
basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java
M
basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepExecution.java
M
basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/WaitForConditionStep.java
M cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
M
cps/src/main/java/org/jenkinsci/plugins/workflow/cps/steps/LoadStepExecution.java
M
step-api/src/main/java/org/jenkinsci/plugins/workflow/steps/AbstractStepExecutionImpl.java
Log Message:
-----------
Merge pull request #161 from jenkinsci/StepExecutionIterator-JENKINS-26163
[JENKINS-26163] Fixed handling of AbstractStepExecutionImpl.onResume
Compare:
https://github.com/jenkinsci/workflow-plugin/compare/fe932961dc7b...fb3e89a31266
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
