Branch: refs/heads/master
Home: https://github.com/jenkinsci/github-plugin
Commit: e573a28c3a3a75890c19512dc899c8da511d2c80
https://github.com/jenkinsci/github-plugin/commit/e573a28c3a3a75890c19512dc899c8da511d2c80
Author: James Nord <[email protected]>
Date: 2015-09-22 (Tue, 22 Sep 2015)
Changed paths:
M src/test/resources/checkstyle/checkstyle-config.xml
Log Message:
-----------
don't be platform specific in checkstyle.
While notable the existing checkstyle means the build is DOA on windows
that uses CRLF as a system linefeed.
Whilst this change enforces unix termination, it will break windows
clients configured with `core.autocrlf=true" but changing files can lead
to platform specific test failures (especially with resource files under
test) so EOL conversion is in this persons eyes evil and to be avoided at
all costs.
It would probably be worthwile to setup .gitattributes in the root of the
repository to stop any eol conversion - but I shall leave that up to the
owners for an excersize at their leisure.
Commit: 727de7d4408a0ef0d71b6d9320e420f6fb3e2855
https://github.com/jenkinsci/github-plugin/commit/727de7d4408a0ef0d71b6d9320e420f6fb3e2855
Author: Merkushev Kirill <[email protected]>
Date: 2015-09-23 (Wed, 23 Sep 2015)
Changed paths:
M src/test/resources/checkstyle/checkstyle-config.xml
Log Message:
-----------
Merge pull request #86 from jtnord/use_lf_in_checkstyle
Don't be platform specific in checkstyle.
Compare:
https://github.com/jenkinsci/github-plugin/compare/60c896c47450...727de7d4408a
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
