Branch: refs/heads/master
Home: https://github.com/jenkinsci/gerrit-trigger-plugin
Commit: 0a8e1c246c1b3bb08733a5ef9345c8f13023a328
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/0a8e1c246c1b3bb08733a5ef9345c8f13023a328
Author: Tyrone Abdy <ta...@redhat.com>
Date: 2016-11-29 (Tue, 29 Nov 2016)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/version/GerritVersionChecker.java
Log Message:
-----------
[JENKINS-40059] CommentAdded trigger firing on every comment
The CommentAdded trigger was firing on any comment after
the necessary value of an approval had been met.
This was happening due to that in previous versions of gerrit
before 2.13.0 approval information only appeared once
something had changed.
This changed to use the oldValue that would optionally
be included on state change. The logic added
to the gerrit-trigger-plugin was based on an earlier
patchset that had an ever present variable for state
change.
This led to a fall through to the old style of checking
for whether to trigger based on a comment.
Commit: a36413b2b88ec89e0e525c08bade676f74e34048
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/a36413b2b88ec89e0e525c08bade676f74e34048
Author: Robert Sandell <rsand...@cloudbees.com>
Date: 2017-04-11 (Tue, 11 Apr 2017)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/version/GerritVersionChecker.java
Log Message:
-----------
Merge pull request #302 from tyroneabdy/master
[JENKINS-40059] CommentAdded trigger firing on every comment
Compare:
https://github.com/jenkinsci/gerrit-trigger-plugin/compare/b0b2c86fb3c9...a36413b2b88e
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
