Branch: refs/heads/master-PRxxx-save-secrets-in-workspace
  Home:   https://github.com/jenkinsci/git-client-plugin
  Commit: 93c668bf4554a083ccf7fa7db93ae1c02ec2d1d1
      
https://github.com/jenkinsci/git-client-plugin/commit/93c668bf4554a083ccf7fa7db93ae1c02ec2d1d1
  Author: Mark Waite <[email protected]>
  Date:   2017-04-11 (Tue, 11 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Note plans in README


  Commit: aff81375be13a63246fd2dfb6af40046d32f21a2
      
https://github.com/jenkinsci/git-client-plugin/commit/aff81375be13a63246fd2dfb6af40046d32f21a2
  Author: Mark Waite <[email protected]>
  Date:   2017-04-11 (Tue, 11 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Change order of the plan


  Commit: 1ac1e1b8328e1d96a2d8755925984b7802d764a9
      
https://github.com/jenkinsci/git-client-plugin/commit/1ac1e1b8328e1d96a2d8755925984b7802d764a9
  Author: Mark Waite <[email protected]>
  Date:   2017-04-11 (Tue, 11 Apr 2017)

  Changed paths:
    M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java

  Log Message:
  -----------
  Detach ssh authenticated git calls from terminal

When I run CredentialsTest from my terminal window on Ubuntu 16.04, the
test fails for ssh keys which need a passphrase.  If I run the tests
from my IDE, or if I prepend "setsid" to the maven command that runs
the tests, the tests pass.

The ssh command called by git seems to require the DISPLAY variable, and
the GIT_SSH variable, and must be detached from the controlling terminal.
If any one of those is missing (at least on Ubuntu 16), the passphrase
prompt will not be answered.


  Commit: 885a453a6fe1f9a6a782be107d9df004717bae32
      
https://github.com/jenkinsci/git-client-plugin/commit/885a453a6fe1f9a6a782be107d9df004717bae32
  Author: Mark Waite <[email protected]>
  Date:   2017-04-11 (Tue, 11 Apr 2017)

  Changed paths:
    M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java

  Log Message:
  -----------
  Only call setsid if program exists


  Commit: 9d8b9eab7c25766eca7ea08063b2fba58a15bd05
      
https://github.com/jenkinsci/git-client-plugin/commit/9d8b9eab7c25766eca7ea08063b2fba58a15bd05
  Author: Mark Waite <[email protected]>
  Date:   2017-04-11 (Tue, 11 Apr 2017)

  Changed paths:
    M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java

  Log Message:
  -----------
  Fix USE_SETSID logic error


  Commit: da7276633fbe0beed420225df40f22da873ce6a0
      
https://github.com/jenkinsci/git-client-plugin/commit/da7276633fbe0beed420225df40f22da873ce6a0
  Author: Mark Waite <[email protected]>
  Date:   2017-04-11 (Tue, 11 Apr 2017)

  Changed paths:
    M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java

  Log Message:
  -----------
  Better diagnostic for setsid use


  Commit: 111b2d7b25c5098431488d8b3df3b63dd1bc6e72
      
https://github.com/jenkinsci/git-client-plugin/commit/111b2d7b25c5098431488d8b3df3b63dd1bc6e72
  Author: Mark Waite <[email protected]>
  Date:   2017-04-11 (Tue, 11 Apr 2017)

  Changed paths:
    M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java

  Log Message:
  -----------
  Remove setsid diagnostics


  Commit: da94a795404ef3271794e47c7511f7fe3eff96de
      
https://github.com/jenkinsci/git-client-plugin/commit/da94a795404ef3271794e47c7511f7fe3eff96de
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Note in README that passphrase tests now run on master


  Commit: 3f9b78659992c7dd39dcf8dd52bc1361073a3d8a
      
https://github.com/jenkinsci/git-client-plugin/commit/3f9b78659992c7dd39dcf8dd52bc1361073a3d8a
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Note in README that passphrase tests are in progress


  Commit: 74c527e55fac9cc232e8457703b692df0755c18d
      
https://github.com/jenkinsci/git-client-plugin/commit/74c527e55fac9cc232e8457703b692df0755c18d
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md
    M src/test/java/org/jenkinsci/plugins/gitclient/CredentialsTest.java

  Log Message:
  -----------
  Added more passphrase tests to auth-data


  Commit: fdba3cf75992440abf5d73e8d8e77e99c694fd57
      
https://github.com/jenkinsci/git-client-plugin/commit/fdba3cf75992440abf5d73e8d8e77e99c694fd57
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M src/test/java/org/jenkinsci/plugins/gitclient/CredentialsTest.java

  Log Message:
  -----------
  Increase CredentialsTest timeout from 7 to 9 secs

One of my old CentOS machines regularly hits the timeout and flakes
several of the tests, slowing the overall run.  Eventually the tests pass,
but they are a little too close to the 7 second edge.

Unfortunately, the longer timeout may be the wrong approach while
investigating failures, since it will cause tests to run the full 9
seconds before they fail, then it will retry the test again (and again)
until the surefire test retry limit is reached.

Most tests complete in less than 1 second, even on the old, slow CentOS
machine. I suspect the issue is load on the ssh server that is answering
the requests.


  Commit: 64b9283ff8b03fd56565254535f0c9a63c79b022
      
https://github.com/jenkinsci/git-client-plugin/commit/64b9283ff8b03fd56565254535f0c9a63c79b022
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M src/test/java/org/jenkinsci/plugins/gitclient/CredentialsTest.java

  Log Message:
  -----------
  Revert "Increase CredentialsTest timeout from 7 to 9 secs"

This reverts commit fdba3cf75992440abf5d73e8d8e77e99c694fd57.

Did not improve the behavior.  Tests which finish successfully still seem
to finish within a second or less, with common times about .25 seconds.
Longest running successful tests complete in just barely under 1 second.


  Commit: ec976da04147fdfbcb09651fe913e1848779987e
      
https://github.com/jenkinsci/git-client-plugin/commit/ec976da04147fdfbcb09651fe913e1848779987e
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java

  Log Message:
  -----------
  Escape passphrase special characters on Windows

Added a passphrase test which includes a '>' character in the passphrase.
The Linux test passes. The Windows test fails.  This attempts to fix
the Windows test.


  Commit: 670452322fb27177c07d7cd3c9a1a7ef1a21e0a1
      
https://github.com/jenkinsci/git-client-plugin/commit/670452322fb27177c07d7cd3c9a1a7ef1a21e0a1
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Still adding passphrase tests


  Commit: 5c4d50890d1cd85dcaebc43146e8ab26cfe00c69
      
https://github.com/jenkinsci/git-client-plugin/commit/5c4d50890d1cd85dcaebc43146e8ab26cfe00c69
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Still adding passphrase tests


  Commit: 240486b082d199046f64d4b2d7d602de1bf244e9
      
https://github.com/jenkinsci/git-client-plugin/commit/240486b082d199046f64d4b2d7d602de1bf244e9
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Another passphrase test


  Commit: 4df042192173252ffaeb46ebc9e386276112b039
      
https://github.com/jenkinsci/git-client-plugin/commit/4df042192173252ffaeb46ebc9e386276112b039
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Add quoted string as test credential


  Commit: 3741b2da6ebee5a85ae501291597c06a203e9fbd
      
https://github.com/jenkinsci/git-client-plugin/commit/3741b2da6ebee5a85ae501291597c06a203e9fbd
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M src/test/java/org/jenkinsci/plugins/gitclient/CredentialsTest.java

  Log Message:
  -----------
  Add jgitapache even if CLI git doesn't do credentials


  Commit: 1d1aceb2ac03b18943d92360cc7e176547555f6b
      
https://github.com/jenkinsci/git-client-plugin/commit/1d1aceb2ac03b18943d92360cc7e176547555f6b
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Add "git.exe" passphrase test


  Commit: 58629ae82bffc1056200be8b6a6282a9fa2406cc
      
https://github.com/jenkinsci/git-client-plugin/commit/58629ae82bffc1056200be8b6a6282a9fa2406cc
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Try again - run tests


  Commit: 9cadcecf8a1c24221a0c64c27c869b7fd74f8cd8
      
https://github.com/jenkinsci/git-client-plugin/commit/9cadcecf8a1c24221a0c64c27c869b7fd74f8cd8
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Add passphrase <mark|earl^waite>@gmail.com


  Commit: 6a77d7d31128c261e61872cdad08abac54b515eb
      
https://github.com/jenkinsci/git-client-plugin/commit/6a77d7d31128c261e61872cdad08abac54b515eb
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Add passphrase abc|cba


  Commit: 61dd90a16bacc75998cff44df4723e5f0f7bbcdf
      
https://github.com/jenkinsci/git-client-plugin/commit/61dd90a16bacc75998cff44df4723e5f0f7bbcdf
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Added passphrase C:(frown


  Commit: 9ab4c7aad32a039b34a99b418c48ba758865bdc2
      
https://github.com/jenkinsci/git-client-plugin/commit/9ab4c7aad32a039b34a99b418c48ba758865bdc2
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Add passphrase D:)smile


  Commit: bce0aee87753e4b4b9566c439bfd01526d0353ce
      
https://github.com/jenkinsci/git-client-plugin/commit/bce0aee87753e4b4b9566c439bfd01526d0353ce
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Add passphrase f(xabc)


  Commit: 658c17c12dba86cdfe3e09e9f593fc81f43b4c41
      
https://github.com/jenkinsci/git-client-plugin/commit/658c17c12dba86cdfe3e09e9f593fc81f43b4c41
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Add passphrase Mark&Earl


  Commit: 90f9801854ea679421a50bb27dacf3adf7974f1d
      
https://github.com/jenkinsci/git-client-plugin/commit/90f9801854ea679421a50bb27dacf3adf7974f1d
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  All test passphrases now added

Run tests to confirm


  Commit: 63090a7a1b0cde4fe7cfcb323778e7322ae38e10
      
https://github.com/jenkinsci/git-client-plugin/commit/63090a7a1b0cde4fe7cfcb323778e7322ae38e10
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  More testing


  Commit: b79be8c16ce1537bc6dcfa0ecdb62839af380aa4
      
https://github.com/jenkinsci/git-client-plugin/commit/b79be8c16ce1537bc6dcfa0ecdb62839af380aa4
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Test x"|date passphrase path fix


  Commit: c668cba3fbfc648ed6444d66bdb885d464de115e
      
https://github.com/jenkinsci/git-client-plugin/commit/c668cba3fbfc648ed6444d66bdb885d464de115e
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M src/test/java/org/jenkinsci/plugins/gitclient/CredentialsTest.java

  Log Message:
  -----------
  Warn if repos.json has passphrase without private key


  Commit: 92d032fe21fee2ed90405b28b027975ab99e8b48
      
https://github.com/jenkinsci/git-client-plugin/commit/92d032fe21fee2ed90405b28b027975ab99e8b48
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
    M src/test/java/org/jenkinsci/plugins/gitclient/CliGitAPIImplAuthTest.java

  Log Message:
  -----------
  Add double quote character to escape list

Double quote character needs to be escaped with a caret character,
just as many of the other special characters are escaped.


  Commit: f2c3afa0b8c5cca62cd0c963c69a3827a081845a
      
https://github.com/jenkinsci/git-client-plugin/commit/f2c3afa0b8c5cca62cd0c963c69a3827a081845a
  Author: Mark Waite <[email protected]>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Show passphrase tests as done in README


Compare: 
https://github.com/jenkinsci/git-client-plugin/compare/93c668bf4554^...f2c3afa0b8c5

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to