Branch: refs/heads/master Home: https://github.com/jenkinsci/pipeline-model-definition-plugin Commit: 71a6001202218266ea16c18f37a86b4af17d7459 https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/71a6001202218266ea16c18f37a86b4af17d7459 Author: Andrew Bayer <andrew.ba...@gmail.com> Date: 2017-05-18 (Thu, 18 May 2017)
Changed paths: M pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/Utils.groovy M pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy M pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/OptionsTest.java M pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ParametersTest.java M pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/TriggersTest.java A pipeline-model-definition/src/test/resources/propsTriggersParamsRemoved.groovy Log Message: ----------- [FIXED JENKINS-44149] Probably clean up old props/triggers/params Previously we weren't calling the properties step if there were no properties (i.e., no job properties from options, no triggers, no parameters), but that left lurking properties when you removed all properties, triggers and parameters from the Jenkinsfile. So now let's check the job config to see if there were *already* defined properties before deciding not to call the properties step. Also make sure that PipelineTriggersJobProperty and ParametersDefinitionProperty are not empty, rather than just present. Commit: ddf519bb72f880d123c70249ceaff68b56c0aedf https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/ddf519bb72f880d123c70249ceaff68b56c0aedf Author: Andrew Bayer <andrew.ba...@gmail.com> Date: 2017-05-19 (Fri, 19 May 2017) Changed paths: M pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/Utils.groovy M pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy M pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/OptionsTest.java M pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ParametersTest.java M pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/TriggersTest.java A pipeline-model-definition/src/test/resources/propsTriggersParamsRemoved.groovy Log Message: ----------- Merge pull request #157 from abayer/jenkins-44149 [FIXED JENKINS-44149] Properly clean up old props/triggers/params Compare: https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/cde871fe3de1...ddf519bb72f8 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.