Branch: refs/heads/master
Home: https://github.com/jenkinsci/jenkins
Commit: bcf55ecd7f8a22046c5cb3c4c50016d936e5460c
https://github.com/jenkinsci/jenkins/commit/bcf55ecd7f8a22046c5cb3c4c50016d936e5460c
Author: Oleg Nenashev <o.v.nenas...@gmail.com>
Date: 2017-07-01 (Sat, 01 Jul 2017)
Changed paths:
M core/src/main/java/hudson/model/AbstractCIBase.java
M core/src/main/java/hudson/model/Node.java
M core/src/main/java/hudson/slaves/RetentionStrategy.java
M core/src/main/java/jenkins/model/Jenkins.java
Log Message:
-----------
[JENKINS-43496] - Add handling of the null Node#createComputer() result.
(#2922)
* [JENKINS-43496] - Add handling of the null Node#createComputer() result.
it is a follow-up to
https://github.com/jenkinsci/jenkins/pull/2836#discussion_r110604865
De-facto many Cloud plugins return `null` in `Node#createLauncher()`, but it
has never been documented.
In order to prevent possible API misusages in the future, I have added
annotations and fixed handling of the extension point in
`AbstractCIBase#updateComputer()` which may fail in the case of `null` or
`RuntimeException` in the Node implementation.
* [JENKINS-43496] - Use ProtectedExternally to protect Node#createComputer()
* [JENKINS-43496] - Remove the erroneous Nonnull annotation after the feedback
from @jglick
* [JENKINS-43496] - Fix typos noticed by @daniel-beck
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
