Branch: refs/heads/master
Home: https://github.com/jenkinsci/git-client-plugin
Commit: c20862dc6064cf31f3c6506b5ccd9de8cb5c9eac
https://github.com/jenkinsci/git-client-plugin/commit/c20862dc6064cf31f3c6506b5ccd9de8cb5c9eac
Author: Mark Waite <[email protected]>
Date: 2017-10-14 (Sat, 14 Oct 2017)
Changed paths:
M src/test/java/org/jenkinsci/plugins/gitclient/CredentialsTest.java
Log Message:
-----------
Test credentials only with getRemoteReferences
The getRemoteReferences test is lighter, and less likely to hit limits
for bandwidth or connection rate from outside services. The same
CliGitAPIImpl code path (launchCommandWithCredentials) is being used,
so the test is valuable, and should fail less frequently.
Commit: 898861502128a1875f904172d89c7df21d4c6032
https://github.com/jenkinsci/git-client-plugin/commit/898861502128a1875f904172d89c7df21d4c6032
Author: Mark Waite <[email protected]>
Date: 2017-10-14 (Sat, 14 Oct 2017)
Changed paths:
M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
Log Message:
-----------
[JENKINS-35959] Don't prompt interactively for credentials
Use git 2.3+ GIT_TERMINAL_PROMPT=0 to prevent git auth prompt.
Older git versions may continue to prompt for interactive credentials,
since they don't recognize the GIT_TERMINAL_PROMPT variable.
Command line git prompts for authentication if connected to a terminal.
Jenkins agents running as a service are not connected to a terminal.
Jenkins agents running from a desktop (Windows or interactive docker)
may run a git process which prompts for authentication. This setting
should reduce the ways that a newer command line git installation can
block. Support for GIT_TERMINAL_PROMPT was first added in git 2.3.
Don't prompt from Git Credentials Manager (Windows).
Refer to
https://github.com/Microsoft/Git-Credential-Manager-for-Windows/blob/105a222711afd00166182b0d95776572a40f57af/Cli-Shared/Program.cs#L62
User can return to old behavior with the CliGitAPIImpl property
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.promptForAuthentication=true
Commit: c29628b28cc6c6326c7769a516b2e87ca1f6194f
https://github.com/jenkinsci/git-client-plugin/commit/c29628b28cc6c6326c7769a516b2e87ca1f6194f
Author: Mark Waite <[email protected]>
Date: 2017-10-14 (Sat, 14 Oct 2017)
Changed paths:
M src/test/java/org/jenkinsci/plugins/gitclient/CredentialsTest.java
Log Message:
-----------
Remove flaky credential tests
Commit: ad9024d43d2d3c086a5bc677acbafe76dbb5b2c4
https://github.com/jenkinsci/git-client-plugin/commit/ad9024d43d2d3c086a5bc677acbafe76dbb5b2c4
Author: Mark Waite <[email protected]>
Date: 2017-10-14 (Sat, 14 Oct 2017)
Changed paths:
M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
M src/test/java/org/jenkinsci/plugins/gitclient/CredentialsTest.java
Log Message:
-----------
Merge pull request #278 from MarkEWaite/use-git-terminal-prompt-env
[JENKINS-35959] Don't prompt for credentials
Compare:
https://github.com/jenkinsci/git-client-plugin/compare/5c9f28d127aa...ad9024d43d2d
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
