* Yes it is the bad practice to put repos in POMs * Yes it many more developers/contributors friendly to add repo in POMs (as far as we don't add not controlled repos and our artifacts aren't supposed to be reused) * Yes it was a bad idea and more generally all this part of projects infra description, users/groups settings ....
As I said to Nicolas & KK at the last hackergarten in Paris I drived a contribution for such mass change : https://gist.github.com/2305867 (by @jeanhelou) Nicolas might probably starts from it. Arnaud On Wed, Apr 4, 2012 at 10:44 PM, Jeff MAURY <jeffma...@jeffmaury.com> wrote: > I think this is a bad Maven design to put repo definition in POM: this is > an infrastructure item, it has nothing to do in POM and lead to people > building repositories in bad places such a github, googlecode, ... > > My 0,5cent > Jeff > > > > On Wed, Apr 4, 2012 at 10:38 PM, nicolas de loof <nicolas.del...@gmail.com > > wrote: > >> jenkins-ci.org is under our control so we can point it to whatever we >> like >> also, plugin can't build without a repo declaration as jenkins artifacts >> aren't available on central >> >> I don't thing this to be a bad practice. Would you expect all developers >> to configure settings with adequate repo to build your project ? This >> *only* is a requirement for deployment on central >> just my 2 cents :P >> >> 2012/4/4 Jeff MAURY <jeffma...@jeffmaury.com> >> >>> You should rather delete this repo definition as it is not a good Maven >>> practice and may lead to the same problem in the future. >>> >>> Jeff >>> >>> >>> >>> On Wed, Apr 4, 2012 at 8:58 PM, nicolas de loof < >>> nicolas.del...@gmail.com> wrote: >>> >>>> Hi folks, >>>> >>>> as you know, glassfish maven repo (aka m.g.o-public) is definitively >>>> off, but we depend on it for many plugins dependencies, and this is >>>> hardcoded in plugin parent pom (so, to get it fixed, plugin would need to >>>> upgrade to a recent jenkins-core dependency). >>>> >>>> some of you may already encounter dependency resolution issues trying >>>> to build a plugin form scratch >>>> >>>> I volunteer to migrate the 400+ plugins to replace <repository> >>>> pointing to m.g.o-public and replace/add repo.jenkins-ci.org/public where >>>> missing, so that each plugin explicitly defines repository to our infra (I >>>> plan to write a tool for that). >>>> >>>> We discussed this on governance meeting, but I wan't to ensure >>>> everybody agree here, so please let me know if you see any drawback or have >>>> another suggestion. >>>> >>>> Nicolas >>>> >>>> >>> >>> >>> -- >>> Jeff MAURY >>> >>> >>> "Legacy code" often differs from its suggested alternative by actually >>> working and scaling. >>> - Bjarne Stroustrup >>> >>> http://www.jeffmaury.com >>> http://riadiscuss.jeffmaury.com >>> http://www.twitter.com/jeffmaury >>> >> >> > > > -- > Jeff MAURY > > > "Legacy code" often differs from its suggested alternative by actually > working and scaling. > - Bjarne Stroustrup > > http://www.jeffmaury.com > http://riadiscuss.jeffmaury.com > http://www.twitter.com/jeffmaury > -- ----- Arnaud Héritier 06-89-76-64-24 http://aheritier.net Mail/GTalk: aherit...@gmail.com Twitter/Skype : aheritier
