Hi Oleg, Actually, the exception you'r describing is exactly the use case for JENKINS-18285 and the reason for the new extension point 'ProjectAuthenticator'. So if you intend to implement the same functionality in a different way, you should take care and know about the behavior of the EP in the core too.
I also had a look at your first release of the plugin and if you don't mind, I have couple of comments: - what is the global configuration for the email suffix for? There is no help for it. But anyway - would it not make more sense to have emails picket up in the users configuration, as ownership probably only makes sense in a secure environment, I guess an owner should also be a registered user? There is also an extension to resolve emails: http://javadoc.jenkins-ci.org/hudson/tasks/MailAddressResolver.html - None of the config fields have any help - the nested checkbox of the "Slave Owner > Enable Ownership" should visible be more nested. The current checkboxes are on the same level and therefore do not visible reflect the nesting. Why are there two boxes anyway, I think "enable ownership" would be enough? - on my JNLP slave the OwnerShip Box is listed twice regards Domi On 11.07.2013, at 21:43, Oleg Nenashev <[email protected]> wrote: > Hello Domi, > > In my opinion, plugin is not directly related to the mentioned Jenkins issues. > > I'm going to implement integration with security plugins (Role Strategy > Plugin) via incoming macro roles support (@Owner, @Co-owner roles will be > added), but I’m not going to have specific “Ownership Strategy” in the > plugin. So, permissions will be handled “as is” by selected strategy. So, > "Authentication" will work properly in 1.520+ versions (if security plugin > supports it, of course). > > BTW, there’s one exception. I’m going to add feature, which allows to > prohibit execution of jobs at the slaves according to ownership (ex, “Accept > jobs only from the following owners…”). Such mechanism can be considered as a > “security” solution, but it doesn’t utilize “Authentication” as well. > Best regards, > Oleg Nenashev > > > 2013/7/11 domi <[email protected]> > Hi Oleg, > sounds good, I like the idea - But I think you should also clarify how this > is related to this https://issues.jenkins-ci.org/browse/JENKINS-18285 - which > is implemented with version 1.520 > and later with this https://issues.jenkins-ci.org/browse/JENKINS-16956 > regards Domi > > On 11.07.2013, at 08:49, Oleg Nenashev <[email protected]> wrote: > >> Hello, >> >> I’m working on the new "Ownership Plugin", which will provide explicit >> ownership of jobs and slaves (more info: >> https://wiki.jenkins-ci.org/display/JENKINS/Ownership+Plugin). >> >> To the best of my knowledge, Jenkins Enterprise provides “Node owners” >> plugin >> (http://jenkins-enterprise.cloudbees.com/docs/user-guide-bundle/nodes-plus-sect-nodeowners.html), >> so I’d like to prevent possible conflicts in plugin naming and appearance. >> >> I would be very appreciated if somebody could answer following questions: >> • What is the name/artifactId/… of the "Node owners" plugin? >> • Is there any functionality excepting e-mail notifications (summary boxes, >> etc.)? >> • Does "Node owners" plugin use any specific resources in the job's >> directories and userContent? >> >> Probably, I should rename plugin in order to avoid confusions. >> >> Thanks in advance, >> Oleg Nenashev, >> R&D Engineer, Synopsys Inc. >> www.synopsys.com >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> >> For more options, visit https://groups.google.com/groups/opt_out. >> >> > > > -- > You received this message because you are subscribed to a topic in the Google > Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/PIUt-NcD8ws/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > > > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
