Hi Magnus, Just a my opinion...
If you provide sorting strategies as an extension point, it will be quite easy to port existing functionality of Priority Sorter as such "strategy". It is possible to implement a one-way migration handler in the plugin, but rollback will be impossible (probably, you mean this issue under backward compatibility). You just need to: * Make the @Extension, which bypasses sortBuildableItems() to the initial implementation * Configure an availability (or just a visibility) of PrioritySorterJobProperty to this extension only * Provide generic visualization approach of priority column (such column is useful in any case) Regarding new plugin, I just aware about the current number of plugins... even if you implement a new plugin and provide automatic migration features, Priority Sorter will be available in the update center with all its bugs, etc. I don't like its priority sorting approach, but it would be useful to minimize plugins number wherever it is possible. BR, Oleg Nenashev четверг, 5 сентября 2013 г., 21:22:23 UTC+4 пользователь Magnus Sandberg написал: > > > Hi Oleg, > > I sort of expected this but ... I opted not to fork the Priority Sorter to > start with because my implementation and core approach is quite different > from the Priority Sorter. > > A merge will be more of replace and I fear that users that likes the way > the Priority Sorter works will be quite disappointed. > > Everything is of-course possible and since the last change to Priority > Sorter is way back then maybe a (most likely) non-backwards compatible 2.0 > release of the Priority Sorter is ok? > > IMHO I do think that a new plugin might be better as it will give users > that want to change a controlled migration - I'm however not hardcore about > it if you feel the Priority Sorter route is preferred. > > > Cheers, > /Magnus > > > > Den torsdagen den 5:e september 2013 kl. 16:09:01 UTC+2 skrev Oleg > Nenashev: >> >> Hi Magnus, >> >> These features would be very useful. >> How do you think, is it possible to merge features from your plugin into >> the https://wiki.jenkins-ci.org/display/JENKINS/Priority+Sorter+Plugin ? >> I suppose that it is the best approach, because this plugin does almost >> the same work, which could become an another strategy in your solution. >> >> Best regards, >> Oleg Nenashev >> >> четверг, 5 сентября 2013 г., 16:19:38 UTC+4 пользователь Magnus Sandberg >> написал: >>> >>> Hi Ulli, >>> >>> It's currently not on github. Can you create an empty repo and I push or >>> do you prefer that I create a repo you can fork? >>> >>> Thanks >>> /Magnus >>> On 5 Sep 2013 09:49, "Ulli Hafner" <[email protected]> wrote: >>> >>>> What is the url of your plugin? Then I'll fork it to our Jenkins >>>> organization... >>>> >>>> Ulli >>>> >>>> Am 04.09.2013 um 22:40 schrieb Magnus Sandberg <[email protected]>: >>>> >>>> >>>> Hi, >>>> >>>> I have created a plugin called "advanced-build-queue-plugin", the >>>> plugin lets you assign priorities to jobs based on if the job exists in a >>>> view and/or based on job name-patterns. >>>> >>>> The plugin currently also support different sorting strategies >>>> (currently "Fair Queueing" and "Weighed Fair Queueing"). >>>> >>>> The plugin is still in beta-stage but I feel it's time to get it into >>>> the Jenkins-repo. >>>> >>>> My GitHub id is "emsa23". >>>> >>>> Thanks, >>>> /Magnus >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Jenkins Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> For more options, visit https://groups.google.com/groups/opt_out. >>>> >>>> >>>> -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
