2014-02-17 18:28 GMT+01:00 Jesse Glick <[email protected]>: > On Mon, Feb 17, 2014 at 12:15 PM, nicolas de loof > <[email protected]> wrote: > > my use case is GitSCM (actually, GitRepositoryBrowser) to expand > attributes > > based on Job.getEnvironment > > how would you handle this ? > > Sounds like core needs to pass in a Job instance whenever calling > RepositoryBrowser methods. Or have some method in RepositoryBrowser > such as RepositoryBrowser forJob(Job) allowing it to be configured for > its particular usage. > > > I don't understand why you consider back-references to be a bad thing. > > Impede testing
Why ? What does it change about testing ? if you have a forJob(Job) method you need a (mocked) job as well to be setup in your test > and are prone to causing memory leaks I'd be surprised JVM can't handle backward references during GC > , accidental massive XStream leakages, Just a question to make @Ancestor extend XStreamOmitField > and so on. > Still don't see a valuable reason to prevent this, compared to a better object model. > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
