>It's bit hackish, but if you copy SecurityListener class definition verbatim into github-oauth-plugin in the "jenkins.security" package and put @Extension(optional=true) to your implementation, then it'd work. >When running in >=1.569 SecurityListener from the core will hide your private copy, so it works as expected. When run in <1.569 it loads fine except nothing happens because no one calls that class.
Thanks Kohsuke, that sounds like a good idea. I implemented it in this pr https://github.com/jenkinsci/github-oauth-plugin/pull/25 Would anyone be kind enough review an possibly merge this pr ( I can make a release if need be, I just want someone to review this, mainly). Surya On Monday, June 30, 2014 2:27:59 PM UTC-5, Kohsuke Kawaguchi wrote: > > Hmm, tough call. IIUC, multiple other plugins depend on > github-oauth-plugin, so it's bit painful to require such a cutting edge > version. But it's tolerable. > > I wonder if it's possible to do that as an optional feature --- that if > you run on >=1.569 you get that functionality, but it still degrades > gracefully for versions before that. > > It's bit hackish, but if you copy SecurityListener class definition > verbatim into github-oauth-plugin in the "jenkins.security" package and put > @Extension(optional=true) to your implementation, then it'd work. When > running in >=1.569 SecurityListener from the core will hide your private > copy, so it works as expected. When run in <1.569 it loads fine except > nothing happens because no one calls that class. > > > > 2014-06-24 5:47 GMT-07:00 Surya <suryap...@gmail.com <javascript:>>: > >> Hi Kohsuke, >> >> I am working on DotCi plugin to refresh githubtoken of a user whenever >> he logs in[1]. For that I needed to add support to fire SecurityListener. >> For that to work however I need to upgrade >> github-oauth-plugin (https://github.com/jenkinsci/github-oauth-plugin) >> to 1.569. >> >> Do you think upgrading to that latest jenkins release would hurt the >> adoption of the github-outh-plugin or impact it in a negative way? >> >> Appreciate your help. Thank you. >> >> >> https://github.com/groupon/DotCi/issues/36 >> -- >> Regards >> Surya >> >> > > > -- > Kohsuke Kawaguchi > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
