I prefer Christopher's technique of placing it in a separate plugin. The git plugin supports many complicated workflows and doesn't have tests to verify all those complicated workflows are still functioning. Using a separate plugin avoids modifying the git plugin and allows users to selectively choose their changes by choosing plugins.
Mark Waite On Wed, Oct 22, 2014 at 3:01 AM, Christopher Orr <ch...@orr.me.uk> wrote: > I think most people are keen to curb the proliferation of advanced > settings in the Git plugin which are only used by a minority of people. > > Also, as far as I can remember, it was Kohsuke who pointed me towards > GitSCMExtension at JUC Berlin and suggested that this doesn't need to be in > the main Git plugin :) > > > > On 22/10/14 06:30, Oleg Nenashev wrote: > >> Chris, is there any need to keep the functionality in a separate plugin? >> IMHO, the functionality is general enough to be merged to the main plugin. >> >> вторник, 21 октября 2014 г., 21:22:41 UTC+4 пользователь Jesse Glick >> написал: >> >> Finally, a GitSCMExtension in another plugin. :-) >> > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to jenkinsci-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Thanks! Mark Waite -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
