Hi James,

Any update regarding my request?

Thanks,
Omer

On Monday, January 12, 2015 at 9:19:27 AM UTC+2, o.hanetz wrote:
>
> Hi James,
>
> I created a pull request with my changes to the plugin.
> However, the plugin maintainer suggested that the changes are better to be 
> included in a new plugin, because they are specific for gruntjs package 
> (and perhaps more packages in the future), and they meant the plugin to be 
> nodejs generic.
>
> Therefore, can you please use my repository to start a new plugin hosted 
> under jenkinsci?
> My github username is ohanetz.
> My forked repository is at https://github.com/ohanetz/nodejs-plugin
> The new plugin might be called nodejs-plugin-extended
>
>
> Thanks,
> Omer
>
> On Friday, January 9, 2015 at 6:20:37 PM UTC+2, James Nord wrote:
>>
>>  Hi Omer,
>>
>> You don't need commit access to create pull requests with changes for a 
>> plugin - this is documented in the link I original sent.
>>
>> Normally you would submit a several pull requests to the plugin and then 
>> approach the maintainer and ask to become a co-maintainer if you wish be 
>> co-responsible for it.
>>
>> /James
>>
>> On 09/01/2015 09:00, o.hanetz wrote:
>>  
>> Thanks James, 
>>
>>  Can you please provide me commit access?
>> My github username is ohanetz.
>>
>>  Thanks,
>> Omer
>>
>> On Friday, January 9, 2015 at 10:07:44 AM UTC+2, James Nord wrote: 
>>>
>>> I Omer
>>>
>>> Yes well written changes to plugins are welcome.
>>>
>>> See 
>>> https://wiki.jenkins-ci.org/display/JENKINS/Governance+Document#GovernanceDocument-Makingchangestoexistingplugins
>>>  
>>> for the process/details
>>>
>>> /James
>>>
>>> On 8 January 2015 19:18:25 GMT+00:00, "o.hanetz" <[email protected]> 
>>> wrote: 
>>>>
>>>> Hi,  
>>>>
>>>>  I would like to use the NodeJS plugin (
>>>> https://wiki.jenkins-ci.org/display/JENKINS/NodeJS+Plugin) to run 
>>>> grunt tasks.
>>>> Since currently grunt is only supported through the command-line in the 
>>>> plugin, I thought I might update the plugin with another build step 
>>>> dedicated for grunt, instead of creating my own plugin from scratch. It 
>>>> will be very helpful for me, and maybe for others in the future.
>>>>
>>>>  Please let me know if I can edit this plugin.
>>>>
>>>>  Thanks,
>>>> Omer
>>>>  
>>>  
>>>   
>>  
>>  

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/d68e04bf-9415-4df9-ad17-ebee9ca5c130%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to